From 21179d3d15900e05bfb796b7280867cf742cde69 Mon Sep 17 00:00:00 2001 From: teor Date: Tue, 28 Jun 2022 09:46:04 +1000 Subject: [PATCH] Checkout zebra in each job to avoid warnings But put TODOs where we might be able to skip checkouts --- .github/workflows/deploy-gcp-tests.yml | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/.github/workflows/deploy-gcp-tests.yml b/.github/workflows/deploy-gcp-tests.yml index e6ae8ed59c7..c3889db24f1 100644 --- a/.github/workflows/deploy-gcp-tests.yml +++ b/.github/workflows/deploy-gcp-tests.yml @@ -91,9 +91,12 @@ jobs: contents: 'read' id-token: 'write' steps: + # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? + # Or will that break the slug-action variables we use to find the instance? - uses: actions/checkout@v3.0.2 with: persist-credentials: false + fetch-depth: '2' - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 @@ -158,9 +161,12 @@ jobs: contents: 'read' id-token: 'write' steps: + # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? + # Or will that break the slug-action variables we use to find the instance? - uses: actions/checkout@v3.0.2 with: persist-credentials: false + fetch-depth: '2' - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 @@ -332,6 +338,8 @@ jobs: contents: 'read' id-token: 'write' steps: + # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? + # Or will that break the slug-action variables we use to find the instance? - uses: actions/checkout@v3.0.2 with: persist-credentials: false @@ -458,9 +466,12 @@ jobs: contents: 'read' id-token: 'write' steps: + # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? + # Or will that break the slug-action variables we use to find the instance? - uses: actions/checkout@v3.0.2 with: persist-credentials: false + fetch-depth: '2' - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 @@ -510,9 +521,12 @@ jobs: contents: 'read' id-token: 'write' steps: + # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? + # Or will that break the slug-action variables we use to find the instance? - uses: actions/checkout@v3.0.2 with: persist-credentials: false + fetch-depth: '2' - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 @@ -563,6 +577,11 @@ jobs: contents: 'read' id-token: 'write' steps: + - uses: actions/checkout@v3.0.2 + with: + persist-credentials: false + fetch-depth: '2' + - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 with: @@ -650,6 +669,13 @@ jobs: contents: 'read' id-token: 'write' steps: + # TODO: can we delete this step and set create_credentials_file to false in Google Cloud? + # Or will that break the slug-action variables we use to find the instance? + - uses: actions/checkout@v3.0.2 + with: + persist-credentials: false + fetch-depth: '2' + - name: Inject slug/short variables uses: rlespinasse/github-slug-action@v4 with: