Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: same conditions found. It is very likely a copy-paste bug. #4642

Closed
ustchcs-bugfinder opened this issue Aug 17, 2020 · 2 comments
Closed
Assignees

Comments

@ustchcs-bugfinder
Copy link

ustchcs-bugfinder commented Aug 17, 2020

SASSERT(x.sbits == y.sbits && x.ebits == y.ebits &&

x.sbits == y.sbits && z.ebits == z.ebits);

x.sbits == y.sbits appears twice.

z.ebits == z.ebits is always true.

It is very likely a copy-paste bug.

SASSERT(x.sbits == y.sbits && x.ebits == y.ebits &&
               x.sbits == y.sbits && z.ebits == z.ebits);   

Reported by: USTCHCS Analysis Toolsuite Bugfinder
(bugfinder-2.3: LHS and RHS of a logical binary-operator (&&, ||), relational/equality binary-operator expression should not contain the same sub-expression.)

@NikolajBjorner
Copy link
Contributor

the bug was reopened but not addressed.

@wintersteiger
Copy link
Contributor

Thanks for the reminder; the check for z.*bits was missing and I was planning to add it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants