Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change unit cell: Test impact of skipping shape / offset part when not used #72

Open
greschd opened this issue Mar 17, 2020 · 0 comments
Open

Change unit cell: Test impact of skipping shape / offset part when not used #72

greschd opened this issue Mar 17, 2020 · 0 comments
Labels
enhancement priority/nice-to-have topic/performance

Comments

@greschd
Copy link
Member

greschd commented Mar 17, 2020

Test the performance impact of skipping the unused parts of the change_unit_cell method when either the unit cell shape does not change, or there is no offset. Especially the former could be important, because it involves solving a few matrix equations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement priority/nice-to-have topic/performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greschd