Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPagePaths does not work correctly if pages folder located inside src folder #3

Closed
MrKiirya opened this issue Feb 15, 2023 · 4 comments · Fixed by #6
Closed

getPagePaths does not work correctly if pages folder located inside src folder #3

MrKiirya opened this issue Feb 15, 2023 · 4 comments · Fixed by #6
Assignees
@Yrobot
Labels
bug Something isn't working

Comments

@MrKiirya
Copy link

MrKiirya commented Feb 15, 2023 •
edited
Loading

getPagePaths does not work correctly if pages folder located inside src folder
there is an error because location of pages is /src/pages/[locale]
image
@Yrobot
Copy link
Owner

Yrobot commented Feb 16, 2023

Hi @MrKiirya , i have reproduced this bug, thanks for your issue.

image

I will try to fix the bug within this days.

@Yrobot Yrobot added the bug Something isn't working label Feb 16, 2023
@Yrobot Yrobot self-assigned this Feb 16, 2023
@Yrobot
Copy link
Owner

Yrobot commented Feb 16, 2023

This is coused by the hard code LOCALE_PATH_PREFIX,

i18next-ssg/src/server/Redirect.tsx

Line 4 in 3fc66b5

const LOCALE_PATH_PREFIX = "pages/[locale]";

@Yrobot Yrobot linked a pull request Feb 16, 2023 that will close this issue
Issue 3 support src pages path #6
Merged
@Yrobot Yrobot closed this as completed in #6 Feb 16, 2023
@Yrobot
Copy link
Owner

Yrobot commented Feb 16, 2023

fix in https://github.com/Yrobot/i18next-ssg/releases/tag/V3.0.2

@Yrobot
Copy link
Owner

Yrobot commented Feb 16, 2023

image

it works fine under my test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yrobot Yrobot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 3 support src pages path Yrobot/i18next-ssg
2 participants
@MrKiirya @Yrobot