Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can't import settings with popup on Firefox #176

Closed
VampireChicken12 opened this issue Dec 15, 2023 · 3 comments
Closed

[Bug] Can't import settings with popup on Firefox #176

VampireChicken12 opened this issue Dec 15, 2023 · 3 comments
Assignees
Labels
bug Something isn't working released

Comments

@VampireChicken12
Copy link
Member

When opening the settings popup by clicking the extension icon then clicking "Import Settings" the file picker appears then the settings popup disappears causing this bug

@VampireChicken12 VampireChicken12 added the bug Something isn't working label Dec 15, 2023
@VampireChicken12 VampireChicken12 self-assigned this Dec 15, 2023
@rado84-github
Copy link

I don't think that this is a bug, it's a perfectly normal behaviour for all extensions. When the file chooser appears, you just navigate to the settings JSON file and select it. Despite that the pop-up is gone, the browser still remembers what you were gonna do, so it will do it, once you select the JSON file. I know, because I tried that and importing settings worked just fine, even without the pop-up being present.

@livingflore livingflore self-assigned this Mar 21, 2024
livingflore added a commit that referenced this issue Mar 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in YouTube Enhancer Mar 21, 2024
github-actions bot pushed a commit that referenced this issue Mar 29, 2024
# [1.24.0](v1.23.3...v1.24.0) (2024-03-29)

### Bug Fixes

* [#176](#176) ([b2fa867](b2fa867))
* applying styles only to a new tab button ([5aa54b2](5aa54b2))
* gainNode being undefined ([cf1f120](cf1f120))
* **hide-shorts:** collapsed shorts side button wasn't hidden ([910c103](910c103))
* jpeg ([3c10720](3c10720))
* select not closing when clicking inside the labels container ([a18637e](a18637e))
* **settings:** Resolve issue where default values weren't being set on existing configuration properties with the type of object ([f10d43d](f10d43d))
* Volume boost was enabled when it wasn't enabled ([4b82a05](4b82a05))

### Features

* open settings in a new tab button ([feaf58e](feaf58e))
* playbackSpeedButtons [#298](#298) ([ea34f9b](ea34f9b))
* YouTube DeepDark built in themes [#381](#381) ([7dfc58c](7dfc58c))

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.24.0-Chrome.zip | f9a92a7c174ff6dc454cf7ad0c4ee8da8d489c08ce83760d822b0ef9f6107e8b |
| youtube-enhancer-v1.24.0-Chromium.zip | f9a92a7c174ff6dc454cf7ad0c4ee8da8d489c08ce83760d822b0ef9f6107e8b |
| youtube-enhancer-v1.24.0-Edge.zip | f9a92a7c174ff6dc454cf7ad0c4ee8da8d489c08ce83760d822b0ef9f6107e8b |
| youtube-enhancer-v1.24.0-Firefox.zip | a8d7d3a3791466ee2415891b11967337359eb7d5854dc3d64b3906f8d7c0988d |
Copy link

🎉 This issue has been resolved in version 1.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Apr 16, 2024
# [1.24.0](v1.23.3...v1.24.0) (2024-04-16)

### Bug Fixes

* [#176](#176) ([b2fa867](b2fa867))
* [#422](#422) ([01e6d7c](01e6d7c))
* applying styles only to a new tab button ([5aa54b2](5aa54b2))
* Checkbox not re-rendering when checked changed ([89f6230](89f6230))
* gainNode being undefined ([cf1f120](cf1f120))
* **hide-shorts:** collapsed shorts side button wasn't hidden ([910c103](910c103))
* jpeg ([3c10720](3c10720))
* localePercentages being undefined ([739fd50](739fd50))
* proper label position when select is visible ([61e186f](61e186f))
* select not closing when clicking inside the labels container ([a18637e](a18637e))
* select overflow issue ([ab0ce5a](ab0ce5a))
* **settings:** Resolve issue where default values weren't being set on existing configuration properties with the type of object ([f10d43d](f10d43d))
* Volume boost was enabled when it wasn't enabled ([4b82a05](4b82a05))

### Features

* open settings in a new tab button ([feaf58e](feaf58e))
* pauseBackgroundPlayers [#249](#249) ([2d4a342](2d4a342))
* playbackSpeedButtons [#298](#298) ([ea34f9b](ea34f9b))
* skipContinueWatching [#403](#403) ([9429774](9429774))
* YouTube DeepDark built in themes [#381](#381) ([7dfc58c](7dfc58c))

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.24.0-Chrome.zip | 699b4f6a0886b8ed0e913a7600c16a78b66b855e1f227b7ec2c5e38765e4fd75 |
| youtube-enhancer-v1.24.0-Chromium.zip | 699b4f6a0886b8ed0e913a7600c16a78b66b855e1f227b7ec2c5e38765e4fd75 |
| youtube-enhancer-v1.24.0-Edge.zip | 699b4f6a0886b8ed0e913a7600c16a78b66b855e1f227b7ec2c5e38765e4fd75 |
| youtube-enhancer-v1.24.0-Firefox.zip | e870309b89cf4465ccc6ea75e7b329fba013258676001b8a742f72085f331df7 |
github-actions bot pushed a commit that referenced this issue Apr 16, 2024
# [1.24.0](v1.23.3...v1.24.0) (2024-04-16)

### Bug Fixes

* [#176](#176) ([b2fa867](b2fa867))
* [#422](#422) ([01e6d7c](01e6d7c))
* applying styles only to a new tab button ([5aa54b2](5aa54b2))
* Checkbox not re-rendering when checked changed ([89f6230](89f6230))
* gainNode being undefined ([cf1f120](cf1f120))
* **hide-shorts:** collapsed shorts side button wasn't hidden ([910c103](910c103))
* jpeg ([3c10720](3c10720))
* localePercentages being undefined ([739fd50](739fd50))
* proper label position when select is visible ([61e186f](61e186f))
* select not closing when clicking inside the labels container ([a18637e](a18637e))
* select overflow issue ([ab0ce5a](ab0ce5a))
* **settings:** Resolve issue where default values weren't being set on existing configuration properties with the type of object ([f10d43d](f10d43d))
* Volume boost was enabled when it wasn't enabled ([4b82a05](4b82a05))

### Features

* open settings in a new tab button ([feaf58e](feaf58e))
* pauseBackgroundPlayers [#249](#249) ([2d4a342](2d4a342))
* playbackSpeedButtons [#298](#298) ([ea34f9b](ea34f9b))
* skipContinueWatching [#403](#403) ([9429774](9429774))
* YouTube DeepDark built in themes [#381](#381) ([7dfc58c](7dfc58c))

## Release Artifacts
| File Name | SHA-256 Hash |
| :--- | :---: |
| youtube-enhancer-v1.24.0-Chrome.zip | d941e8a2f2e410c06b722a1e643092d8e82be6dbfce0d3fa60c8629974b497b9 |
| youtube-enhancer-v1.24.0-Chromium.zip | d941e8a2f2e410c06b722a1e643092d8e82be6dbfce0d3fa60c8629974b497b9 |
| youtube-enhancer-v1.24.0-Edge.zip | d941e8a2f2e410c06b722a1e643092d8e82be6dbfce0d3fa60c8629974b497b9 |
| youtube-enhancer-v1.24.0-Firefox.zip | 66a45c2cafbdb19eff5a32a2bab2451f2cbc02f5f177c303888cbd80f095b57c |
Copy link

🎉 This issue has been resolved in version 1.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
Status: Done
Development

No branches or pull requests

3 participants