Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return type in the documentation for ilisi/clisi #113

Closed
timtreis opened this issue Oct 4, 2023 · 1 comment · Fixed by #182
Closed

Incorrect return type in the documentation for ilisi/clisi #113

timtreis opened this issue Oct 4, 2023 · 1 comment · Fixed by #182
Labels
bug Something isn't working

Comments

@timtreis
Copy link

timtreis commented Oct 4, 2023

Report

Extremely minor but I'm currently extracting a few bits from "under the hood". Noticed that the return type of the ilisi_knn and clisi_knn calculations are incorrect. According to https://scib-metrics.readthedocs.io/en/stable/generated/scib_metrics.ilisi_knn.html it's ilisi Array of shape (n_cells,) with the iLISI score for each cell. but due to

ilisi = np.nanmedian(lisi)
it's a single float. Analog for clisi

Version information

No response

@timtreis timtreis added the bug Something isn't working label Oct 4, 2023
@adamgayoso
Copy link
Member

Thanks! Happy to accept a PR with the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants