Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop chrono, use std Time #7

Closed
0xpr03 opened this issue Aug 25, 2017 · 3 comments
Closed

Drop chrono, use std Time #7

0xpr03 opened this issue Aug 25, 2017 · 3 comments

Comments

@0xpr03
Copy link
Contributor

0xpr03 commented Aug 25, 2017

It would be best to drop chrono and use std time, as chrono has some serious problems regarding conversion etc, you're kind of locked into the chrono universe as it is now.

@Yoric
Copy link
Owner

Yoric commented Aug 28, 2017

I have no real opinion on this. What are the problems with chrono, exactly? And is std::time powerful enough that we can get away with using just std::time?

@0xpr03
Copy link
Contributor Author

0xpr03 commented Aug 28, 2017

My main issue with chrono is it's golden cage, there are issues open since a longer time regarding conversion from chrono time to the std time etc. It's brilliant in parsing etc, but can be a real pain if you have to get out of the normal chrono universe.
One big enhancement is also, that std::time won't be changed that much anymore, as it's now inside the std, breaking timer.rs less often.
As long as we're updating timer.rs accordingly it won't be a problem, otherwise it is.

So: I'm biased.

@0xpr03
Copy link
Contributor Author

0xpr03 commented Nov 5, 2017

I'm closing this as chrono seems to do it's job and I'm against changing one of the essential input/ouput types of a working library if there's no hard fact why this would be required.

@0xpr03 0xpr03 closed this as completed Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants