implement derivedState + derivedParam #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw0517tw
reviewed
Apr 30, 2018
src/index.js
Outdated
| if (arg && typeof arg !== 'object') { | ||
| warning( | ||
| false, | ||
| 'should not provide not object type param with derivedParam. derivedParam will not be applied.' |
tw0517tw
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Calvin-Lin @kidkcl @wtflink
加上了指定 state 跟 param 的地方，相容以下兩種回傳格式
derivedState會在執行 action 前 setStatederivedParam會放到 action 執行時的第二個參數