-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX improvements to snippet preview #13192
Comments
The radio buttons are based on those from Material UI. You can take some inspiration from their repo: https://github.com/mui-org/material-ui/tree/3f56ea14dbb964578eebe4258b50b2a0426c8cfb |
@hedgefield During the scrum meeting, we decided to not collapse the edit fields by default, because that pushes the SEO analysis down to much. |
@IreneStr, @thijsdevalk and I decided a while ago to replace the radio buttons for a toggle switch. But after some consideration, I decided that this use case isn't suited for a toggle switch after all. For now, we'll stick to using radio buttons. |
The radio buttons will not be styled like the material-ui components within this issue. After some consideration, for consistency's sake, the decision was made that a component should be created for all radio buttons, not only the ones in the scope of this issue. A separate issue will be created to redesign all radio buttons. In this issue default radio buttons will be used. (CC @luckickken ) |
This issue has a PR in both the javascript and wordpress-seo repo. |
Testing #13649 I'm wondering how this new title would look like in other languages, typically the ones that have longer translations. For example, in Italian would be translated to:
Especially in the sidebar, the available space is pretty limited: With this specific sentence, I think most of the western languages will have longer translations. I'd suggest to consider a shorter title, which I guess should be evaluated by product. |
Oh well it's singular so it would be: |
I see in the design issue a first idea was to rename the title to "Google preview", which is way shorter and maybe more immediate. https://github.com/Yoast/design/issues/394#issuecomment-497673161
|
Lets go with @afercia Could you make a separate issue to replace the occurrences of |
Sure will do. |
Fixed in Yoast/javascript#376 and #13649 |
Is your feature request related to a problem? Please describe.
The current toggle to switch between the mobile and desktop snippet preview is unclear. Based on the discussion about UX and a11y in this design issue, we have an approved product solution to build.
Describe the solution you'd like
Google search result preview
cc @IreneStr
The text was updated successfully, but these errors were encountered: