Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing or empty X-B3-Sampled #73

Open
drolando opened this issue Mar 27, 2018 · 0 comments
Open

Support missing or empty X-B3-Sampled #73

drolando opened this issue Mar 27, 2018 · 0 comments

Comments

@drolando
Copy link
Contributor

Right now, we are ignoring the pyramid_zipkin path/route blacklist in firehose mode, which means firehose mode is emitting spans for things like /status.

We can support this more generally by not firehose tracing when X-B3-Sampled=0 and only sampling when it is 1 or absent (see https://github.com/openzipkin/b3-propagation for details on this)

This will be a little bit tricky because pyramid_zipkin and py_zipkin do not correctly implement this nuance of the b3 spec. py_zipkin's create_http_headers_for_new_span doesn't support X-B3-Sampled being absent, and pyramid_zipkin does not set zipkin_attrs.is_sampled to None when a trace decision is deferred (i.e. absent X-B3-Sampled)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant