-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sending spans in batches #6
Comments
@kaisen, @bplotnick What about this? AFAIK Zipkin serer can process batch spans. At least we might modify log_spans to send root span and self.log_handler.client_spans together. What do you think? I could give a try on this. |
@kaisen, @bplotnick Guys, your thoughts on this? |
@dmitry-prokopchenkov Go for it! You could make |
@bplotnick ok, thanks! |
@bplotnick just a reminder, this can be closed |
The Zipkin Kafka collector supports receiving batches of spans instead of single spans after openzipkin/zipkin#995. However, having a py_zipkin user implement batching solely in the transport_handler seems like it'd be too difficult on their part.
Maybe we could support having
ZipkinLoggingContext
take a batch_size param that defaults to something large but sane (20?), then in log_spans we could call transport_handler with a list of thrift-encoded spans as opposed to a single span at a time.@kaisen, thoughts?
The text was updated successfully, but these errors were encountered: