Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async transport_handler example and update docs #56

Open
bplotnick opened this issue Aug 4, 2017 · 0 comments
Open

Add async transport_handler example and update docs #56

bplotnick opened this issue Aug 4, 2017 · 0 comments

Comments

@bplotnick
Copy link
Contributor

It's not very clear from the docs that spans are sent when the root request context closes. In #55, it was suggested to have an async transport_handler example, which is a good idea. We should also suggest closing the span context outside of the critical path as is done in pyramid-zipkin and flask-zipkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant