Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tornado Instrumentation for PyZipkin #125

Open
jstrfd opened this issue Apr 8, 2019 · 2 comments
Open

Tornado Instrumentation for PyZipkin #125

jstrfd opened this issue Apr 8, 2019 · 2 comments

Comments

@jstrfd
Copy link

jstrfd commented Apr 8, 2019

Could an instrumentation for the Python Tornado Web Framework please be added? Thank you.

@codefromthecrypt
Copy link

fyi I looked around the web and didn't find much... some go the WSGI middleware route

Back in the day, uber had a tornado tracer. I suspect this might be a port of that https://github.com/opentracing-contrib/python-tornado/tree/master/tornado_opentracing Note: I don't recommend copy/pasting code like this as it can lead to both bugs and license issues.

@drolando
Copy link
Contributor

What exactly are you looking for? What would you want to instrument in tornado?

As far as I know tornado is a server engine, not a web framework. So you'll probably use some other framework on top of it (i.e. pyramid, flask or django). Those are probably the ones you should be looking to instrument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants