From 63097f37ef3d33bf54e91b318a2892154191e97f Mon Sep 17 00:00:00 2001 From: gavanderhoorn Date: Tue, 2 Apr 2024 14:46:27 +0200 Subject: [PATCH 1/2] Use separate directory for external dependencies Clearly separate them from MotoROS2 proper and additionally, prevent GCC from treating them as part of MotoROS2 itself (conversely, prevent GCC from treating MotoROS2 sources as 'external', and thus disabling many of its checks and warnings). --- {src => lib}/CmosParameterExtraction.h | 0 {src => lib}/CmosParameterTypes.h | 0 {src => lib}/MotoPlusExterns.h | 0 {src => lib}/MotoROS_PlatformLib.dnLib | Bin {src => lib}/MotoROS_PlatformLib.h | 0 {src => lib}/MotoROS_PlatformLib.yrcLib | Bin {src => lib}/MotoROS_PlatformLib.yrcmLib | Bin {src => lib}/ParameterExtraction.dnLib | Bin {src => lib}/ParameterExtraction.yrcLib | Bin {src => lib}/ParameterExtraction.yrcmLib | Bin src/MotoROS2_AllControllers.vcxproj | 56 ++++++++++---------- src/MotoROS2_AllControllers.vcxproj.filters | 18 +++---- 12 files changed, 37 insertions(+), 37 deletions(-) rename {src => lib}/CmosParameterExtraction.h (100%) rename {src => lib}/CmosParameterTypes.h (100%) rename {src => lib}/MotoPlusExterns.h (100%) rename {src => lib}/MotoROS_PlatformLib.dnLib (100%) rename {src => lib}/MotoROS_PlatformLib.h (100%) rename {src => lib}/MotoROS_PlatformLib.yrcLib (100%) rename {src => lib}/MotoROS_PlatformLib.yrcmLib (100%) rename {src => lib}/ParameterExtraction.dnLib (100%) rename {src => lib}/ParameterExtraction.yrcLib (100%) rename {src => lib}/ParameterExtraction.yrcmLib (100%) diff --git a/src/CmosParameterExtraction.h b/lib/CmosParameterExtraction.h similarity index 100% rename from src/CmosParameterExtraction.h rename to lib/CmosParameterExtraction.h diff --git a/src/CmosParameterTypes.h b/lib/CmosParameterTypes.h similarity index 100% rename from src/CmosParameterTypes.h rename to lib/CmosParameterTypes.h diff --git a/src/MotoPlusExterns.h b/lib/MotoPlusExterns.h similarity index 100% rename from src/MotoPlusExterns.h rename to lib/MotoPlusExterns.h diff --git a/src/MotoROS_PlatformLib.dnLib b/lib/MotoROS_PlatformLib.dnLib similarity index 100% rename from src/MotoROS_PlatformLib.dnLib rename to lib/MotoROS_PlatformLib.dnLib diff --git a/src/MotoROS_PlatformLib.h b/lib/MotoROS_PlatformLib.h similarity index 100% rename from src/MotoROS_PlatformLib.h rename to lib/MotoROS_PlatformLib.h diff --git a/src/MotoROS_PlatformLib.yrcLib b/lib/MotoROS_PlatformLib.yrcLib similarity index 100% rename from src/MotoROS_PlatformLib.yrcLib rename to lib/MotoROS_PlatformLib.yrcLib diff --git a/src/MotoROS_PlatformLib.yrcmLib b/lib/MotoROS_PlatformLib.yrcmLib similarity index 100% rename from src/MotoROS_PlatformLib.yrcmLib rename to lib/MotoROS_PlatformLib.yrcmLib diff --git a/src/ParameterExtraction.dnLib b/lib/ParameterExtraction.dnLib similarity index 100% rename from src/ParameterExtraction.dnLib rename to lib/ParameterExtraction.dnLib diff --git a/src/ParameterExtraction.yrcLib b/lib/ParameterExtraction.yrcLib similarity index 100% rename from src/ParameterExtraction.yrcLib rename to lib/ParameterExtraction.yrcLib diff --git a/src/ParameterExtraction.yrcmLib b/lib/ParameterExtraction.yrcmLib similarity index 100% rename from src/ParameterExtraction.yrcmLib rename to lib/ParameterExtraction.yrcmLib diff --git a/src/MotoROS2_AllControllers.vcxproj b/src/MotoROS2_AllControllers.vcxproj index 7e3d6c01..0ddf6ce2 100644 --- a/src/MotoROS2_AllControllers.vcxproj +++ b/src/MotoROS2_AllControllers.vcxproj @@ -126,109 +126,109 @@ "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_h" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)DX200\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);DX200;MOTOROS2_MEM_TRACE_ENABLE - $(MP_VS_Install)DX200\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)DX200\inc;$(SolutionDir)libmicroros_dx200_humble\include; + $(MP_VS_Install)DX200\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)DX200\inc;$(SolutionDir)libmicroros_dx200_humble\include;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_h" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)DX200\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_h" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_dx200_humble\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_dx200_humble\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_g" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)DX200\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);DX200;MOTOROS2_MEM_TRACE_ENABLE - $(MP_VS_Install)DX200\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)DX200\inc;$(SolutionDir)libmicroros_dx200_galactic\include; + $(MP_VS_Install)DX200\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)DX200\inc;$(SolutionDir)libmicroros_dx200_galactic\include;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_g" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)DX200\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_g" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_dx200_galactic\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_dx200_galactic\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_f" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)DX200\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);DX200;MOTOROS2_MEM_TRACE_ENABLE - $(MP_VS_Install)DX200\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)DX200\inc;$(SolutionDir)libmicroros_dx200_foxy\include; + $(MP_VS_Install)DX200\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)DX200\inc;$(SolutionDir)libmicroros_dx200_foxy\include;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_f" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)DX200\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_dx2_f" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_dx200_foxy\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_dx200_foxy\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_h" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);YRC1000;MOTOROS2_MEM_TRACE_ENABLE - $(MP_VS_Install)YRC1000\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000\inc;$(SolutionDir)libmicroros_yrc1000_humble\include; + $(MP_VS_Install)YRC1000\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000\inc;$(SolutionDir)libmicroros_yrc1000_humble\include;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_h" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_h" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_yrc1000_humble\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_yrc1000_humble\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_g" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);YRC1000;MOTOROS2_MEM_TRACE_ENABLE - $(ProjectDir)..\libmicroros_yrc1000_galactic\include;$(MP_VS_Install)YRC1000\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000\inc; + $(ProjectDir)..\libmicroros_yrc1000_galactic\include;$(MP_VS_Install)YRC1000\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000\inc;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_g" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_g" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_yrc1000_galactic\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_yrc1000_galactic\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_f" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);YRC1000;MOTOROS2_MEM_TRACE_ENABLE - $(ProjectDir)..\libmicroros_yrc1000_foxy\include;$(MP_VS_Install)YRC1000\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000\inc; + $(ProjectDir)..\libmicroros_yrc1000_foxy\include;$(MP_VS_Install)YRC1000\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000\inc;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_f" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1_f" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_yrc1000_foxy\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_yrc1000_foxy\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_h" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000u\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);YRC1000u;MOTOROS2_MEM_TRACE_ENABLE - $(MP_VS_Install)YRC1000u\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000u\inc;$(SolutionDir)libmicroros_yrc1000u_humble\include; + $(MP_VS_Install)YRC1000u\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000u\inc;$(SolutionDir)libmicroros_yrc1000u_humble\include;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_h" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000u\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_h" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_yrc1000u_humble\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_yrc1000u_humble\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_g" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000u\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);YRC1000u;MOTOROS2_MEM_TRACE_ENABLE - $(ProjectDir)..\libmicroros_yrc1000u_galactic\include;$(MP_VS_Install)YRC1000u\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000u\inc; + $(ProjectDir)..\libmicroros_yrc1000u_galactic\include;$(MP_VS_Install)YRC1000u\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000u\inc;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_g" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000u\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_g" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_yrc1000u_galactic\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_yrc1000u_galactic\include; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_f" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000u\inc" $(MP_VS_Install)DevTools\OnlineDownload.exe $(NMakePreprocessorDefinitions);YRC1000u;MOTOROS2_MEM_TRACE_ENABLE - $(ProjectDir)..\libmicroros_yrc1000u_foxy\include;$(MP_VS_Install)YRC1000u\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000u\inc; + $(ProjectDir)..\libmicroros_yrc1000u_foxy\include;$(MP_VS_Install)YRC1000u\gnu\4.3.3-vxworks-6.9\lib\gcc\i586-wrs-vxworks\4.3.3\include;$(MP_VS_Install)YRC1000u\inc;$(SolutionDir)lib; "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_f" -b "$(SolutionDir)bin\$(Configuration)" -o build -i "$(MP_VS_Install)YRC1000u\inc" "$(MP_VS_Install)mpBuilder.exe" -c $(Configuration) -p "$(ProjectDir)\" -n "mr2_yrc1m_f" -b "$(OutDir)\" -o clean $(SolutionDir)bin\$(Configuration)\ - $(ProjectDir)..\libmicroros_yrc1000u_foxy\include; + $(ProjectDir)..\lib;$(ProjectDir)..\libmicroros_yrc1000u_foxy\include; @@ -294,12 +294,12 @@ - - - - - - + + + + + + @@ -369,7 +369,7 @@ - + @@ -384,14 +384,14 @@ - - + + - + diff --git a/src/MotoROS2_AllControllers.vcxproj.filters b/src/MotoROS2_AllControllers.vcxproj.filters index 96571cdc..6b585860 100644 --- a/src/MotoROS2_AllControllers.vcxproj.filters +++ b/src/MotoROS2_AllControllers.vcxproj.filters @@ -109,22 +109,22 @@ Compile Settings - + MotoPlus Libraries - + MotoPlus Libraries - + MotoPlus Libraries - + MotoPlus Libraries - + MotoPlus Libraries - + MotoPlus Libraries @@ -410,13 +410,13 @@ Header Files - + MotoPlus Libraries - + MotoPlus Libraries - + MotoPlus Libraries From 77a2903e2b07b47fc1d0c232f5678ca7fb9caa4a Mon Sep 17 00:00:00 2001 From: gavanderhoorn Date: Tue, 2 Apr 2024 15:38:21 +0200 Subject: [PATCH 2/2] Libs are now in 'lib' dir, update REUSE metadata --- .reuse/dep5 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.reuse/dep5 b/.reuse/dep5 index 310bc955..9de29b9c 100644 --- a/.reuse/dep5 +++ b/.reuse/dep5 @@ -20,11 +20,11 @@ Files: src/*.mps Copyright: 2022-2023 Yaskawa America, Inc. License: Apache-2.0 -Files: src/ParameterExtraction.* +Files: lib/ParameterExtraction.* Copyright: 2013-2023 Yaskawa America, Inc. License: BSD-3-Clause -Files: src/MotoROS_PlatformLib.*Lib +Files: lib/MotoROS_PlatformLib.*Lib Copyright: 2023 Yaskawa America, Inc. 2023, Delft University of Technology License: Apache-2.0