Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS: clean target fails: include directory not found #131

Open
gavanderhoorn opened this issue Aug 23, 2023 · 2 comments
Open

VS: clean target fails: include directory not found #131

gavanderhoorn opened this issue Aug 23, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@gavanderhoorn
Copy link
Collaborator

As per subject really.

Whenever I try to build the clean target of the VS project, I get:

Clean started...
1>------ Clean started: Project: MotoROS2, Configuration: DX200_foxy Win32 ------
1>EXEC : error : Include directory not found - C:\...\MotoPlus for Visual Studio\DX200_foxy\inc
1>mpBuilder : error : Problem with mpBuilder - Invalid Include Directory
1>C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.MakeFile.Targets(38,5): error MSB3073: The command ""C:\...\MotoPlus for Visual Studio\mpBuilder.exe" -c DX200_foxy -p "C:\...\motoros2\src\\" -n "MotoROS2" -b "C:\...\motoros2\DX200_foxy\\" -o clean" exited with code 1.
1>Done building project "MotoROS2_AllControllers.vcxproj" -- FAILED.
========== Clean: 0 succeeded, 1 failed, 0 skipped ==========

this aborts the build.

PS: it would also seem the build command still uses MotoROS2 for the -n option. Not sure whether that's a problem or not.

@gavanderhoorn gavanderhoorn added the bug Something isn't working label Aug 23, 2023
@ted-miller
Copy link
Collaborator

Looks like a bug in M+SDK.

Short-term, it shouldn't be a problem. Every build is technically a clean-rebuild since there is no incremental build system with mpbuilder.

I'll get it fixed sometime in September.

Note to self: This applies to v1.5.1 of M+SDK.

@gavanderhoorn
Copy link
Collaborator Author

Testing the new SDK build, I now see a different error:

------ Clean started: Project: MotoROS2, Configuration: YRC1000u_humble Win32 ------
C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.CppClean.targets(77,5): error MSB4044: The "CppClean" task was not given a value for the required parameter "FoldersToClean".
Done building project "MotoROS2_AllControllers.vcxproj" -- FAILED.

less 'error-y', but still not quite working.

On another mpBuilder project it does work though (MotoROS_PlatformLib), so perhaps the VS project is missing some (required) configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants