Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hayabusa 2+ shows long underlines in help menu #911

Closed
YamatoSecurity opened this issue Feb 7, 2023 · 7 comments · Fixed by #967
Closed

Hayabusa 2+ shows long underlines in help menu #911

YamatoSecurity opened this issue Feb 7, 2023 · 7 comments · Fixed by #967
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

It seems that after updating to Clap 4, Hayabusa prints long underlines in Command Prompt.
I think this is a bug in Clap though so may need to get them to fix upstream.

@hitenkoku What do you think? should we raise an issue to the Clap repository to have them look at it?

underbar

@hitenkoku hitenkoku added the under-investigation under investigation to develop label Feb 8, 2023
@hitenkoku
Copy link
Collaborator

I checked following enviroments. Underlines didn't show up in my environment...

  • PowerShellv5(Windows 11 via terminal app)
  • cmd.exe(Windows11 via terminal app)
  • PowerShell v7(Windows 11 via terminal app)

@YamatoSecurity
Copy link
Collaborator Author

Humm.. from start -> run as command, if you open cmd.exe without using the terminal app, does it also not show?
Maybe this is just a problem with my environment. Btw, using Windows 10

@hitenkoku
Copy link
Collaborator

Yes, underlines didn't show up when following way.

Humm.. from start -> run as command, if you open cmd.exe without using the terminal app, does it also not show?

Sorry, I don't have Windows 10 environment now.

Maybe this is just a problem with my environment. Btw, using Windows 10

@fukusuket
Copy link
Collaborator

I have the same issue in the following environment :(

  • Windows 10 Home(and Pro) Edition
  • PowerShell 7or cmd.exe

It may be a problem that can be reproduced only with Windows 10... 🤔 I will also check the reproduction conditions.

@fukusuket
Copy link
Collaborator

I found the following same issue in clap repo :)
clap-rs/clap#4431

@hitenkoku
Copy link
Collaborator

@fukusuket Thanks for checking!

Since it is difficult to fix as hayabusa, and we need to deal with fixing dependent libraries, we have added a "waiting for dependencies crate update" tag.

@hitenkoku hitenkoku removed the under-investigation under investigation to develop label Feb 10, 2023
@YamatoSecurity
Copy link
Collaborator Author

This was fixed in clap 4.1.10
clap-rs/clap#4431 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants