Skip to content
This repository has been archived by the owner on Jan 6, 2018. It is now read-only.

Not working with ( #4

Closed
gpbl opened this issue Feb 18, 2015 · 3 comments · May be fixed by #7
Closed

Not working with ( #4

gpbl opened this issue Feb 18, 2015 · 3 comments · May be fixed by #7

Comments

@gpbl
Copy link
Contributor

gpbl commented Feb 18, 2015

This kind of statements will not match:

debug('This is myVar: ' + (myVar) + '.');

(spotted something similar in fluxible)

I'd suggest to use a wider regexp pattern, such as

var regexPattern = new RegExp('\\n[ \\t]*(' + toStrip + ').*;?', 'g');

that would just match, for example, debug(.

If you believe it's OK I can send a PR :)
@Vijar
Copy link
Contributor

Vijar commented Feb 18, 2015

I like it! Feel free to do a PR.

@gpbl gpbl mentioned this issue Feb 20, 2015
Closed
@Vijar Vijar mentioned this issue Feb 22, 2015
Open
@chiefjester
Copy link

@Vijar I see there are open PRs, got bitten by this bug as well, when using substring inside a console.log basically ended up with nested parentheses.

Looking forward to the PR so we can update.

@Vijar
Copy link
Contributor

Vijar commented Jan 30, 2016

Fixed by #11

@Vijar Vijar closed this as completed Jan 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use recast to strip functions YahooArchive/strip-loader
3 participants
@gpbl @chiefjester @Vijar