Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Humble or later #33

Open
flochre opened this issue Oct 28, 2023 · 4 comments
Open

Not working with Humble or later #33

flochre opened this issue Oct 28, 2023 · 4 comments

Comments

@flochre
Copy link

flochre commented Oct 28, 2023

Hi guys,

I was experiencing problem with the branch working on Humble, and I am not too fan of the solution in the humble branch because all the files are executable with is useless and not a good practice.

So I created a few pull request to change this.
Please see here the pull requests opened today

#30 (this one reused #19)
#31
#32

If nobody wants to merge them you can use my repo.. all pull request are merged in my main branch : https://github.com/flochre/ydlidar_ros2_driver

@flochre
Copy link
Author

flochre commented Oct 28, 2023

I added a PR #34 to get Rviz Launch working also

@umicar1234
Copy link

i am still not able to build this in my RPI 4 works on ubuntu 22.0 ros2 iron

@sanjana1999
Copy link

i am still not able to build this in my RPI 4 works on ubuntu 22.0 ros2 iron

Facing the same issue. Did you find any solution?

@umicar1234
Copy link

Yes, I solved it, it only support upto ros2 humble, only few changes have to be done in c++ file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants