Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a Band Streak (Combo) counter to YARG, which is displayed underneath the Score Box during gameplay. Although the total Band Streak was previously tracked internally, this code has been reworked and expanded.
Band Streaks can be enabled in the Experimental Settings menu. Three modes are available:
All instruments should be supported, although vocals requires special consideration:
To make room for the Band Streak counter, this PR also moves the entire score box up, closer to the vocal highway. This improves, but does not eliminate, issues such as this one on Discord
The graphic for the band streak box is temporary, and an update for it is "Planned".
Note for the reviewer: In the current implementation, much of the streak counting logic resides in the YARG codebase, which is not ideal. Although it would make sense to have this in YARG.Core instead, its infrastructure doesn't really support this yet. We may want to revisit this once Unison Phrases are added to the game.
Requires YARG.Core PR YARC-Official/YARG.Core#223