Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIFBUILDER not working in resolutionConfigs #96

Open
Josta opened this issue Jan 26, 2017 · 3 comments
Open

GIFBUILDER not working in resolutionConfigs #96

Josta opened this issue Jan 26, 2017 · 3 comments

Comments

@Josta
Copy link

Josta commented Jan 26, 2017

The problem is that the function Tx_Yag_Domain_ImageProcessing_Typo3Processor->getImageResource() is expected to return a ProcessedFile instance. The underlaying core function ContentObjectRenderer->getImgResource() however only creates a ProcessedFile for a non-GIFBUILDER image resource. This means getImageResource() returns NULL in case of a GIFBUILDER resource input, which in turn causes an error in Tx_Yag_Domain_ImageProcessing_Typo3Processor->processFile.

The bug was confirmed with TYPO3 7.6.12 and YAG 4.1.2 .

@infabo
Copy link
Contributor

infabo commented Mar 23, 2017

Can confirm with TYPO3 7.6.16 and YAG 4.2.1.

See this commit: f314d22

@echavaillaz
Copy link

Can confirm this bug! Is it possible to resolve it?

@Poepp
Copy link

Poepp commented Jan 26, 2018

I can also confirm this bug with TYPO3 7.6.23 and YAG 4.2.1.
I resolved it for me by using older versions of AbstractProcessor.php and Typo3Processor.php. Namely I got back to this commit 72fbc6a and used the versions of this classes before the change.
Maybe it helps someone to solve his problem(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants