diff --git a/.github/workflows/check_milvus_proto.yml b/.github/workflows/check_milvus_proto.yml index 019dc1e20..2c6239f50 100644 --- a/.github/workflows/check_milvus_proto.yml +++ b/.github/workflows/check_milvus_proto.yml @@ -26,7 +26,7 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip - pip install -e . + pip install -e ".[dev]" - name: Try generate proto run: | diff --git a/.github/workflows/code_checker.yml b/.github/workflows/code_checker.yml index f19985c73..8a15b70d4 100644 --- a/.github/workflows/code_checker.yml +++ b/.github/workflows/code_checker.yml @@ -19,7 +19,7 @@ jobs: uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - - name: check pyproject.toml install + - name: Check pyproject.toml install run: | pip install -e . - name: Install requirements diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 18a22691b..73cc36cb3 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -8,10 +8,11 @@ on: jobs: build: name: Run Python Tests - runs-on: ubuntu-latest strategy: matrix: python-version: [3.8, 3.12] + os: [ubuntu-latest, windows-latest] + runs-on: ${{ matrix.os }} steps: - name: Checkout code diff --git a/Makefile b/Makefile index 2dfd51128..642fa4043 100644 --- a/Makefile +++ b/Makefile @@ -25,7 +25,7 @@ get_proto: git submodule update --init gen_proto: - python3 -m pip install -e ".[dev]" + pip install -e ".[dev]" cd pymilvus/grpc_gen && ./python_gen.sh check_proto_product: gen_proto diff --git a/pyproject.toml b/pyproject.toml index e048c40ff..a58ddb537 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -24,7 +24,7 @@ dependencies=[ "ujson>=2.0.0", "pandas>=1.2.4", "numpy<1.25.0;python_version<='3.8'", - "milvus-lite>=2.4.0", + "milvus-lite>=2.4.0;sys_platform!='win32'", ] classifiers=[ diff --git a/tests/test_milvus_lite.py b/tests/test_milvus_lite.py index ef4f49274..0149fd5bc 100644 --- a/tests/test_milvus_lite.py +++ b/tests/test_milvus_lite.py @@ -1,12 +1,14 @@ import os +import sys from tempfile import TemporaryDirectory import numpy as np +import pytest from pymilvus.milvus_client import MilvusClient +@pytest.mark.skipif(sys.platform.startswith('win'), reason="Milvus Lite is not supported on Windows") class TestMilvusLite: - def test_milvus_lite(self): with TemporaryDirectory(dir='./') as root: db_file = os.path.join(root, 'test.db')