Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per socket options #2424

Closed
totaam opened this issue Sep 23, 2019 · 5 comments
Closed

per socket options #2424

totaam opened this issue Sep 23, 2019 · 5 comments
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 23, 2019

Based on #1160, we can re-use the same generic socket properties to configure more obscure socket settings like TCP_NODELAY (#619) and TCP_CORK (#2130).

@totaam
Copy link
Collaborator Author

totaam commented Sep 23, 2019

r23896 does this for TCP_CORK and TCP_NODELAY, ie:

xpra start --start=xterm :10 --bind-tcp=0.0.0.0:10000,auth=file:filename=password.txt,cork=0,nodelay=1

Other things we can use this for:

  • mdns=off
  • ssl upgrade options
  • limit the types of connections we can accept? (ie: info+version only)

@totaam
Copy link
Collaborator Author

totaam commented Sep 23, 2019

r23904 makes it possible to disable mdns on a per-socket basis, ie:

xpra start --no-daemon --bind-tcp=0.0.0.0:10000,mdns=no --bind-tcp=0.0.0.0:10001,mdns=yes

SSL wrapping is more difficult because it takes so many arguments, and we're not currently storing them but taking them from the config object directly.
So they would need to be copied as attributes in the server object so we can re-use them later.

@totaam
Copy link
Collaborator Author

totaam commented Oct 22, 2019

Moving SSL to #2460 and SSH to #2583

@totaam totaam closed this as completed Oct 22, 2019
@totaam
Copy link
Collaborator Author

totaam commented Jun 2, 2020

For client connection strings, see #2794.

@totaam
Copy link
Collaborator Author

totaam commented Oct 12, 2020

As of r27656, the socket options can also be used to configure socket protocol upgrades:

xpra start --start=xterm --bind-tcp=0.0.0.0:10000,ssh=0,http=0,https=1,ssl=1,ssl-cert=./ssl-cert.pem

ie: this allows plain tcp and https / wss, bit not http or ssh upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant