x264 quality regression

[totaam]

Issue migrated from trac ticket # 2087

component: encodings | priority: critical | resolution: fixed

2018-12-19 01:37:46: antoine created the issue

---

Discovered as part of #2086, the picture is really messed up despite the high quality setting.

This is what it looks like:
[[Image(tkdiff.png)]]

The changelog is here: [/log/xpra/trunk/src/xpra/codecs/enc_x264].
What stands out:

• r21114 threading
• r20519 preset
• r20399 bandwidth limit
• r20392 "grain" tuning for text content - probably not the one (manually reverted to test)

[totaam]

2018-12-19 01:38:09: antoine uploaded file tkdiff.png (234.5 KiB)

tkdiff very degraded

[totaam]

2018-12-19 01:43:32: antoine changed status from new to assigned

[totaam]

2018-12-19 01:43:32: antoine edited the issue description

[totaam]

2018-12-19 17:53:40: nathan_lstc commented

---

I have updated and deployed to this user. He reports that with --video-encoders=vpx,nvenc things are much better.

Thank you.

[totaam]

2018-12-19 18:03:29: antoine changed priority from major to critical

[totaam]

2018-12-19 18:03:29: antoine commented

---

• r20392 OK
• r20519 bad
• r20399 bad

So the problem comes from bandwidth-limit integration (r20399)

[totaam]

2018-12-19 18:22:30: antoine changed status from assigned to closed

[totaam]

2018-12-19 18:22:30: antoine set resolution to fixed

[totaam]

2018-12-19 18:22:30: antoine commented

---

Fixed in r21249. (was some left-over test code)