Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interleaving network packets #1124

Closed
totaam opened this issue Feb 17, 2016 · 2 comments
Closed

interleaving network packets #1124

totaam opened this issue Feb 17, 2016 · 2 comments
Labels
network wontfix This will not be worked on
Milestone

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 17, 2016

Some packets can be quite big, in particular 'paint' and 'file-transfer' packets.

It would be nice if we could chunk them to allow other types of packets through without delay.
ie: allowing sound packets through more quickly, which would keep the client's sound queue at a lower level and is better for achieving sound sync (#835).

This is very likely to overlap with UDP (#639) and file chunking (#1026). It would be nice to find a solution generic enough to work with both TCP and UDP.

Things to think about:

  • the receive buffers could consume a lot of memory
  • how many packets can be interleaved? (not more than 1 I think)
  • UDP re-transmit for file chunking
  • paint packet may then arrive after a window has been resized or minimized - which may cause errors..
  • encryption..
  • sound queue adjustments to tolerate packet loss
  • ping packets: it would actually be useful to have both delayed and undelayed ones? would tell us how much is being interleaved?
@totaam
Copy link
Collaborator Author

totaam commented Jun 13, 2016

#1026 was done a different way because it really is special, so now we can delay this ticket - which is much more difficult and should probably only be done after UDP and other network tweaks, if ever.
If needed, we can handle large paint packets by splitting the damage into smaller regions, which will then travel in separate packets.

@totaam totaam added network wontfix This will not be worked on labels Jan 23, 2021
@totaam totaam added this to the future milestone Jan 23, 2021
@totaam
Copy link
Collaborator Author

totaam commented May 22, 2021

Too difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
network wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant