Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace javascript crypto library with jsSHA #29

Closed
totaam opened this issue Feb 29, 2020 · 5 comments
Closed

replace javascript crypto library with jsSHA #29

totaam opened this issue Feb 29, 2020 · 5 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Feb 29, 2020 •
edited
Loading

jsSHA looks much more compact than forge.
@totaam
Copy link
Collaborator Author

totaam commented Jun 13, 2020 •
edited
Loading

This may help with #8.

@totaam
Copy link
Collaborator Author

totaam commented Jun 29, 2020 •
edited
Loading

jsSHA is great and could be used for hmac authentication, but it doesn't handle AES...
So maybe we can just use the crypto API and drop IE11 support.

Examples here: webcrypto-examples.

@totaam
Copy link
Collaborator Author

totaam commented Jun 29, 2020 •
edited
Loading

Big problem with browser crypto is that this relies on asynchronous promises, which would require a huge rewrite of the protocol layer which is sequential by nature.

Maybe asmcrypto.js instead? It handles both AES and HMAC with a synchronous API. (and this fork has documentation)

@totaam
Copy link
Collaborator Author

totaam commented Jun 29, 2020

2020-06-29 16:17:48: antoine uploaded file asmcrypto.patch (6.4 KiB)

attempting to switch over

@totaam totaam transferred this issue from Xpra-org/xpra Jan 23, 2021
@totaam totaam mentioned this issue Mar 24, 2021
Closed
@totaam
Copy link
Collaborator Author

totaam commented May 4, 2022

#8 has been fixed, no real need for this now.

@totaam totaam closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@totaam