Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently not grabbing 1080p versions of shows and not showing Resolution correctly #86

Open
axipher opened this issue Mar 11, 2019 · 75 comments

Comments

@axipher
Copy link

axipher commented Mar 11, 2019

See below attachment, two different shows both giving the same result of "DEBUG: video_resolution : x"

The actual downloaded file is also 720p instead of 1080p as my settings indicate.

error.log.txt

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

I have the same problem

I'm tinkering with the code, I may have a temporary solution

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

It seems that there was changes on the xml response

Previously, the xml would contain:

<metadata>
  <width>848</width>
  <height>480</height>
  <duration>1234.56</duration>
</metadata>

But now it looks like this:

<metadata>
  <width></width>
  <height></height>
  <duration>1234.56</duration>
</metadata>

That explains why the resolution is "x", the width and the height is empty

@Abu3safeer
Copy link
Contributor

@Nicnl So it is from Crunchyroll side.
even the HTML5 web player does not offer resolution options.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

Along with that, it seems that there's some issues with those requests:

if str(resolution).lower() in ['1080p', '1080', 'fhd', 'best']:
info_url = "http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=%s&video_format=108&video_quality=80&current_page=%s" % (
video_id, url)
elif str(resolution).lower() in ['720p', '720', 'hd']:
info_url = "http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=%s&video_format=106&video_quality=62&current_page=%s" % (
video_id, url)
elif str(resolution).lower() in ['480p', '480', 'sd']:
info_url = "http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=%s&video_format=106&video_quality=61&current_page=%s" % (
video_id, url)
elif str(resolution).lower() in ['360p', '360', 'cancer']:
info_url = "http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=%s&video_format=106&video_quality=60&current_page=%s" % (
video_id, url)

The parameter video_quality seems to be ignored for some reason

However, when I try to print the content of the master.m3u8 file from this part of the code:

m3u8_file_text = m3u8_file_connect.text.splitlines()[2]

It seems to contain all the resolutions:

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=1280x720,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=1280x720,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=1280x720,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=1920x1080,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=1920x1080,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=1920x1080,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxx

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

Ok I made a pull request

#88

"It works on my end"

I'll try to pack the .exe files for those who want

@axipher
Copy link
Author

axipher commented Mar 11, 2019

If you can, that would be great and I can test it quickly using my script that pulls a bunch of shows.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

Here is a packed version

anime-dl.exe

The fix is really disgusting though
And Crunchyroll seems to be changing a lot their servers and all
I have no idea how long it will last

@Abu3safeer
Copy link
Contributor

I wish these changes for better.

@axipher
Copy link
Author

axipher commented Mar 11, 2019

Not working on my end with your packaged EXE, it's also 9708 KB vs 8418 KB of the previous version.

I get the following error printed in the console:
Could not extract the language from the URL

And this is my Error.log:

DEBUG: You have successfully set the Debugging On.
DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-23-saved-souls-780740'], language='Japanese', password=['<password>'], range='All', resolution=['1080p'], skip=False, username=['<username>'], verbose=True, version=False)
DEBUG: Operating System : Windows - 10 - 10.0.17134
DEBUG: Python Version : 2.7.15 (64bit)

And this is my PowerScript logfile form my script I run for a bunch of shows:

**********************
Windows PowerShell transcript start
Start time: 20190311181209
Username: CACHE-VM-WIN10\cayde
RunAs User: CACHE-VM-WIN10\cayde
Configuration Name: 
Machine: CACHE-VM-WIN10 (Microsoft Windows NT 10.0.17134.0)
Host Application: PowerShell.exe -noexit -command Set-Location -literalPath 'D:\Crunchyroll'
Process ID: 12168
PSVersion: 5.1.17134.590
PSEdition: Desktop
PSCompatibleVersions: 1.0, 2.0, 3.0, 4.0, 5.0, 5.1.17134.590
BuildVersion: 10.0.17134.590
CLRVersion: 4.0.30319.42000
WSManStackVersion: 3.0
PSRemotingProtocolVersion: 2.3
SerializationVersion: 1.1.0.1
**********************
Transcript started, output file is anime-dl-weekly_20190311T1812096274Z.log
Could not extract the language from the URL
**********************
Windows PowerShell transcript end
End time: 20190311181216
**********************

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

Ooooh shit, I know
My local working copy was not up to date and it did not have the fix for this #77

@Abu3safeer
Copy link
Contributor

Hello @Xonshiz , how are you doing?
could you please give @Nicnl the ability to merge pull requests and release some updates?
I know you are busy, that is why I would like you to have him helping you in this project.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

Ok, I repacked it with the subtitles fix

anime-dl.exe

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

@Abu3safeer

Let me know if it's fixed

@axipher
Copy link
Author

axipher commented Mar 11, 2019

Still not working correctly.

Console Output:

Trying to login...
Logged in successfully...
Seems like this video isn't available...
'NoneType' object has no attribute 'group'

Error Log:

DEBUG: You have successfully set the Debugging On.
DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-23-saved-souls-780740'], language='Japanese', password=['<password>'], range='All', resolution=['1080p'], skip=False, username=['<username>'], verbose=True, version=False)
DEBUG: Operating System : Windows - 10 - 10.0.17134
DEBUG: Python Version : 2.7.15 (64bit)
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "POST //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "GET /that-time-i-got-reincarnated-as-a-slime/episode-23-saved-souls-780740 HTTP/1.1" 200 None
DEBUG: video_id : 780740
DEBUG: info_url : http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=780740&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-23-saved-souls-780740
DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=780740&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-23-saved-souls-780740 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=780740&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-23-saved-souls-780740 HTTP/1.1" 200 None

@axipher
Copy link
Author

axipher commented Mar 11, 2019

Let me try it on a previous episode that I know has a 1080p video

@axipher
Copy link
Author

axipher commented Mar 11, 2019

Okay, so it errors on a different step on the previous episode that I know has 1080p video download from alst week, and the current Web Player has a 1080p version.

Console Output:

Trying to login...
Logged in successfully...
Seems like this video isn't available...
'NoneType' object has no attribute 'group'

Error.log

DEBUG: You have successfully set the Debugging On.
DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739'], language='Japanese', password=['<password>'], range='All', resolution=['1080p'], skip=False, username=['<username>'], verbose=True, version=False)
DEBUG: Operating System : Windows - 10 - 10.0.17134
DEBUG: Python Version : 2.7.15 (64bit)
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "POST //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "GET /that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739 HTTP/1.1" 200 None
DEBUG: video_id : 780739
DEBUG: info_url : http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=780739&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739
DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=780739&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=780739&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739 HTTP/1.1" 200 None
DEBUG: m3u8_file_link : https://dl.v.vrv.co/evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: anime_name : That Time I Got Reincarnated As A Slime
DEBUG: episode_number : 22
DEBUG: video_resolution : 1920x1080
DEBUG: file_name : That Time I Got Reincarnated As A Slime - 22 [1920x1080].mp4
DEBUG: 
----- Subs Downloading Started -----

DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346456 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346456 HTTP/1.1" 200 None
DEBUG: iv : cGqnD3qH5pA85GgjaR9ybA==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346446 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346446 HTTP/1.1" 200 None
DEBUG: iv : XGhMLxt5jqLy14BIvldV7Q==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346445 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346445 HTTP/1.1" 200 None
DEBUG: iv : S1qxpHAjGKvdG44pc9TacA==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346458 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346458 HTTP/1.1" 200 None
DEBUG: iv : xphB7mSXYscFYzbPeQhHYQ==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346435 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346435 HTTP/1.1" 200 None
DEBUG: iv : jVwhlRnbsjiSYXNIgQt1Vg==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346477 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346477 HTTP/1.1" 200 None
DEBUG: iv : nM1PKkAtT9VOczfrZ2q0Ow==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346460 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346460 HTTP/1.1" 200 None
DEBUG: iv : qDFFDoFW49uRZTP7+umQgw==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346461 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346461 HTTP/1.1" 200 None
DEBUG: iv : fuzngPBFOsrwudSNmCbEzA==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346963 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=346963 HTTP/1.1" 200 None
DEBUG: iv : CJDkcBO+BUAop6Ulp8mYvg==
DEBUG: 
----- Subs Downloaded -----

DEBUG: Starting new HTTPS connection (1): dl.v.vrv.co:443
DEBUG: https://dl.v.vrv.co:443 "GET /evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: Starting new HTTPS connection (1): a-vrv.akamaized.net:443
DEBUG: https://a-vrv.akamaized.net:443 "GET /evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

@Abu3safeer
Copy link
Contributor

It was not showing 1080p quality, but now it works:

General
Format                      : Matroska
Format version              : Version 4 / Version 2
File size                   : 987 MiB
Duration                    : 24 min 11 s
Overall bit rate            : 5 701 kb/s
Encoded date                : UTC 2019-03-11 18:39:17
Writing application         : mkvmerge v31.0.0 ('Dolores In A Shoestand') 64-bit
Writing library             : libebml v1.3.6 + libmatroska v1.4.9

Video
ID                          : 1
Format                      : AVC
Format/Info                 : Advanced Video Codec
Format profile              : High@L4
Format settings             : CABAC / 4 Ref Frames
Format settings, CABAC      : Yes
Format settings, ReFrames   : 4 frames
Codec ID                    : V_MPEG4/ISO/AVC
Duration                    : 24 min 10 s
Bit rate                    : 5 576 kb/s
Width                       : 1 920 pixels
Height                      : 1 080 pixels
Display aspect ratio        : 16:9
Frame rate mode             : Constant
Frame rate                  : 23.976 (24000/1001) FPS
Color space                 : YUV
Chroma subsampling          : 4:2:0
Bit depth                   : 8 bits
Scan type                   : Progressive
Bits/(Pixel*Frame)          : 0.112
Stream size                 : 964 MiB (98%)
Writing library             : x264 core 142
Encoding settings           : cabac=1 / ref=4 / deblock=1:1:1 / analyse=0x3:0x113 / me=umh / subme=8 / psy=1 / psy_rd=0.40:0.00 / mixed_ref=1 / me_range=16 / chroma_me=1 / trellis=1 / 8x8dct=1 / cqm=0 / deadzone=21,11 / fast_pskip=1 / chroma_qp_offset=-2 / threads=12 / lookahead_threads=2 / sliced_threads=0 / nr=0 / decimate=1 / interlaced=0 / bluray_compat=0 / constrained_intra=0 / bframes=3 / b_pyramid=2 / b_adapt=2 / b_bias=0 / direct=3 / weightb=1 / open_gop=0 / weightp=2 / keyint=9999999 / keyint_min=5000000 / scenecut=0 / intra_refresh=0 / rc_lookahead=50 / rc=crf / mbtree=1 / crf=15.0 / qcomp=0.60 / qpmin=0 / qpmax=69 / qpstep=4 / vbv_maxrate=8000 / vbv_bufsize=12000 / crf_max=0.0 / nal_hrd=none / filler=0 / ip_ratio=1.40 / aq=1:0.60
Default                     : Yes
Forced                      : No

Audio
ID                          : 2
Format                      : AAC LC
Format/Info                 : Advanced Audio Codec Low Complexity
Codec ID                    : A_AAC-2
Duration                    : 24 min 10 s
Bit rate                    : 128 kb/s
Channel(s)                  : 2 channels
Channel layout              : L R
Sampling rate               : 44.1 kHz
Frame rate                  : 43.066 FPS (1024 SPF)
Compression mode            : Lossy
Delay relative to video     : -83 ms
Stream size                 : 22.1 MiB (2%)
Default                     : Yes
Forced                      : No

Text #1
ID                          : 3
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 9 s
Bit rate                    : 159 b/s
Count of elements           : 414
Compression mode            : Lossless
Stream size                 : 28.2 KiB (0%)
Title                       : English(US)
Language                    : English
Default                     : Yes
Forced                      : No

Text #2
ID                          : 4
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 8 s
Bit rate                    : 227 b/s
Count of elements           : 451
Compression mode            : Lossless
Stream size                 : 40.2 KiB (0%)
Title                       : Deutsch
Language                    : German
Default                     : No
Forced                      : No

Text #3
ID                          : 5
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 11 s
Bit rate                    : 120 b/s
Count of elements           : 342
Compression mode            : Lossless
Stream size                 : 21.3 KiB (0%)
Title                       : Espanol(Espana)
Language                    : Spanish
Default                     : No
Forced                      : No

Text #4
ID                          : 6
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 11 s
Bit rate                    : 119 b/s
Count of elements           : 342
Compression mode            : Lossless
Stream size                 : 21.2 KiB (0%)
Title                       : Espanol
Language                    : Spanish
Default                     : No
Forced                      : No

Text #5
ID                          : 7
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 8 s
Bit rate                    : 150 b/s
Count of elements           : 359
Compression mode            : Lossless
Stream size                 : 26.6 KiB (0%)
Title                       : Francais(France)
Language                    : French
Default                     : No
Forced                      : No

Text #6
ID                          : 8
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 9 s
Bit rate                    : 155 b/s
Count of elements           : 376
Compression mode            : Lossless
Stream size                 : 27.5 KiB (0%)
Title                       : Italiano
Language                    : Italian
Default                     : No
Forced                      : No

Text #7
ID                          : 9
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 9 s
Bit rate                    : 165 b/s
Count of elements           : 412
Compression mode            : Lossless
Stream size                 : 29.3 KiB (0%)
Title                       : Portugues(Brasil)
Language                    : Portuguese
Default                     : No
Forced                      : No

Text #8
ID                          : 10
Format                      : ASS
Codec ID                    : S_TEXT/ASS
Codec ID/Info               : Advanced Sub Station Alpha
Duration                    : 24 min 8 s
Bit rate                    : 197 b/s
Count of elements           : 410
Compression mode            : Lossless
Stream size                 : 34.9 KiB (0%)
Title                       : und
Default                     : No
Forced                      : No

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

:[

Sorry @axipher, I have no idea what's happening...

I was searching and trying things to reproduce your issue without any luck

And now that it works with Abu3safeer, I'm completely lost

@axipher
Copy link
Author

axipher commented Mar 11, 2019

@Abu3safeer what show/episode was the one you ahve that works? I can try that on my end.

Alternatively, can you try episode 22 of "That Time I Got Reincarnated As A Slime":

https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739

This is the full command I'm running:

.\anime-dl.exe -v -i https://www.crunchyroll.com/that-time-i-got-reincarnated-as-a-slime/episode-22-conquering-the-labyrinth-780739 -u <username> -p <password> -r 1080p

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

@axipher

I removed my entire local copy, redownloaded the dependencies, reapplied the patch and tried making a "cleaner" build

anime-dl.exe

Sorry for making you go though all this...

@axipher
Copy link
Author

axipher commented Mar 11, 2019

@Nicnl Still same error, tried on a completely different show. If I remove the "-r 1080p" it oddly enough tries to pull 720p version on the second pass

Console Command and log:

PS D:\Crunchyroll> .\anime-dl.exe -v -i https://www.crunchyroll.com/sword-art-online/episode-1
9-the-seal-of-the-right-eye-781426 -u <username> -p <password> -r 1080p
Trying to login...
Logged in successfully...
Downloading Sword Art Online Alicization - 19 [1920x1080].enUS.ass ...
Downloading Sword Art Online Alicization - 19 [1920x1080].esLA.ass ...
Downloading Sword Art Online Alicization - 19 [1920x1080].ptBR.ass ...
Could not find the requested resolution Sword Art Online Alicization - 19 [1920x1080].mp4 in the m3u8 file

PS D:\Crunchyroll> .\anime-dl.exe -v -i https://www.crunchyroll.com/sword-art-online/episode-1
9-the-seal-of-the-right-eye-781426 -u <username> -p <password>
Trying to login...
Logged in successfully...
Downloading Sword Art Online Alicization - 19 [1280x720].enUS.ass ...
Downloading Sword Art Online Alicization - 19 [1280x720].esLA.ass ...
Downloading Sword Art Online Alicization - 19 [1280x720].ptBR.ass ...
Could not find the requested resolution Sword Art Online Alicization - 19 [1280x720].mp4 in the m3u8 file

Error Log:

DEBUG: You have successfully set the Debugging On.
DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426'], language='Japanese', password=['<password>'], range='All', resolution=['1080p'], skip=False, username=['<username>'], verbose=True, version=False)
DEBUG: Operating System : Windows - 10 - 10.0.17134
DEBUG: Python Version : 2.7.15 (64bit)
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "POST //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "GET /sword-art-online/episode-19-the-seal-of-the-right-eye-781426 HTTP/1.1" 200 None
DEBUG: video_id : 781426
DEBUG: info_url : http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=781426&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426
DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=781426&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=781426&video_format=108&video_quality=80&current_page=https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426 HTTP/1.1" 200 None
DEBUG: m3u8_file_link : https://dl.v.vrv.co/evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: anime_name : Sword Art Online Alicization
DEBUG: episode_number : 19
DEBUG: video_resolution : 1920x1080
DEBUG: file_name : Sword Art Online Alicization - 19 [1920x1080].mp4
DEBUG: 
----- Subs Downloading Started -----

DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345923 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345923 HTTP/1.1" 200 None
DEBUG: iv : tUgmcIdHjiuXFoo4W/aptg==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345890 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345890 HTTP/1.1" 200 None
DEBUG: iv : huiy7xc2n6tN9x1ATgzKpg==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345942 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345942 HTTP/1.1" 200 None
DEBUG: iv : /8+p9JIX9eiXh08VsnU1Xw==
DEBUG: 
----- Subs Downloaded -----

DEBUG: Starting new HTTPS connection (1): dl.v.vrv.co:443
DEBUG: https://dl.v.vrv.co:443 "GET /evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: Starting new HTTPS connection (1): a-vrv.akamaized.net:443
DEBUG: https://a-vrv.akamaized.net:443 "GET /evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx











DEBUG: You have successfully set the Debugging On.
DEBUG: Arguments Provided : Namespace(input=['https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426'], language='Japanese', password=['<password>'], range='All', resolution='720p', skip=False, username=['<username>'], verbose=True, version=False)
DEBUG: Operating System : Windows - 10 - 10.0.17134
DEBUG: Python Version : 2.7.15 (64bit)
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "POST //login HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /login HTTP/1.1" 200 None
DEBUG: https://www.crunchyroll.com:443 "GET /sword-art-online/episode-19-the-seal-of-the-right-eye-781426 HTTP/1.1" 200 None
DEBUG: video_id : 781426
DEBUG: info_url : http://www.crunchyroll.com/xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=781426&video_format=106&video_quality=62&current_page=https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426
DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=781426&video_format=106&video_quality=62&current_page=https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiVideoPlayer_GetStandardConfig&media_id=781426&video_format=106&video_quality=62&current_page=https://www.crunchyroll.com/sword-art-online/episode-19-the-seal-of-the-right-eye-781426 HTTP/1.1" 200 None
DEBUG: m3u8_file_link : https://dl.v.vrv.co/evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: anime_name : Sword Art Online Alicization
DEBUG: episode_number : 19
DEBUG: video_resolution : 1280x720
DEBUG: file_name : Sword Art Online Alicization - 19 [1280x720].mp4
DEBUG: 
----- Subs Downloading Started -----

DEBUG: Starting new HTTP connection (1): www.crunchyroll.com:80
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345923 HTTP/1.1" 301 None
DEBUG: Starting new HTTPS connection (1): www.crunchyroll.com:443
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345923 HTTP/1.1" 200 None
DEBUG: iv : g6J9V1p+3k3Qe1Pk5ckUjw==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345890 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345890 HTTP/1.1" 200 None
DEBUG: iv : YMztsVim4Ca3WvPsn1rdrw==
DEBUG: http://www.crunchyroll.com:80 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345942 HTTP/1.1" 301 None
DEBUG: https://www.crunchyroll.com:443 "GET /xml/?req=RpcApiSubtitle_GetXml&subtitle_script_id=345942 HTTP/1.1" 200 None
DEBUG: iv : ++jJVNvXLQQCLwhtEh0/QQ==
DEBUG: 
----- Subs Downloaded -----

DEBUG: Starting new HTTPS connection (1): dl.v.vrv.co:443
DEBUG: https://dl.v.vrv.co:443 "GET /evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
DEBUG: Starting new HTTPS connection (1): a-vrv.akamaized.net:443
DEBUG: https://a-vrv.akamaized.net:443 "GET /evs/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

If you omit the -r argument, a default value of 720p is used:

parser.add_argument('-r', '--resolution', nargs=1, help='Inputs the URL to anime.', default='720p')

So, that's not really an odd behaviour

What's odd is that, for some reason, the 1080p video is missing from the downloaded master.m3u8 file

I would just advise you to edit the error logs you pasted
Especially those lines:

  • DEBUG: m3u8_file_link : https://dl.v.vrv.co/evs/xxxxxxxxxxxxxxxxxxxxxxxx
  • DEBUG: https://dl.v.vrv.co:443 "GET /evs/xxxxxxxxxxxxxxxxxxxx
  • DEBUG: https://a-vrv.akamaized.net:443 "GET /evs/xxxxxxxxxxxxxxxxxx

Those URLs contains private tokens

Sorry, I permitted myself to download two of them, notably the slime and sword art online

After stripping them of any important data, here what they looks like

This one is the slime I think

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx

There's only: 240p, 360p and 480p

And this one the SAO

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1234567,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.123456,mp4a.40.2"
https://xxxxxxxxxxxxxxxxxxxxxxx

Again, there's only 240p, 360p and 480p

I have no idea why you don't have a better video quality, maybe crunchyroll treats users differently depending on the country?

@metita
Copy link

metita commented Mar 11, 2019

Can confirm.

@axipher
Copy link
Author

axipher commented Mar 11, 2019

@Nicnl Thanks for the tip on the private keys. Also normally I do get 1080p of everything in Canada. I wonder if Crunchyroll is just making some weird changes to stuff. Not sure what else I can provide you to help out here.

@Abu3safeer
Copy link
Contributor

@axipher do you have premium account? do you use it in the command?
since @Nicnl said you only had 480p it means you don't have premium account, since free accounts only have 480p as highest quality.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

Yeah, now that I think of it
When I was tinkering with the code two month ago, I stumbled the part that handles the login

And... uh... it doesn't check if you're actually connected or not
Whatever the login you enter are, it will always write "login successful"

So if you enter wrong credentials, it will show login successful BUT you won't be able to download 1080p shows or get the exclusive episode of the week

So, uh, @axipher, maybe you could triple check your account status and credentials?
Or if you changed your password recently, have you used special characters such as %, %, , etc?
The windows terminal don't like some of them when they're not escaped properly

@Nicnl
Copy link
Contributor

Nicnl commented Mar 11, 2019

@basuritashka

This is an experimental patch for the 1080p download resolution issue

  • anime-dl.exe

If you could try it out and tell if it works, it'd be great!

@Abu3safeer
Copy link
Contributor

Wiered, this is from the experimental patch!

image

@aspablo
Copy link

aspablo commented Mar 26, 2019

@Nicnl I am able stream on my browser though. And I get the resolution selection options as well.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 26, 2019

Yes, but well

In the existing anime-dl, there's a big flaw concerning how the authentication is handled

Basically, the authentication is NOT checked
You can enter whatever login you want, you'll always get "Logged in succesfully", which is stupid

I've tried to fix this on a fork

@aspablo

Could you try this version?

  • anime-dl.exe

What changes in this version:

  • If the authentication fails for some reason, it'll try to spit out the error message
  • If the requested resolution is not available in the master.m3u8 file, it'll list the available resolutions

@Abu3safeer
Copy link
Contributor

Same here, this is weird:

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=953424,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.4d401f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=500945,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=387101,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.42c015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx

@aspablo
Copy link

aspablo commented Mar 26, 2019

@Nicnl Tried the linked exe. Still same error
image
Error Log.log

Edit:

image
I can stream it fine though

@Abu3safeer
Copy link
Contributor

Whoh, what is happening here!
image

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=953424,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.4d401f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=500945,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=387101,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.42c015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxx.mp4/index-v1-a1.m3u8?t=xxxx

@Nicnl
Copy link
Contributor

Nicnl commented Mar 26, 2019

Wait guys, there's something wrong
Maybe I've linked the wrong build, you sould have more logs than just "could not find"

@Abu3safeer
Copy link
Contributor

The funny thing that I add /ar/ language to the link and now it works
image

@aspablo
Copy link

aspablo commented Mar 26, 2019

How are you guys extracting the resolutions info from the m3u8 links?

@aspablo
Copy link

aspablo commented Mar 26, 2019

@Abu3safeer lemme check

@aspablo
Copy link

aspablo commented Mar 26, 2019

ohho ho yes.. it worked!
image
But didn't you already fix the region issue since it contained extra '/'? @Nicnl

@Nicnl
Copy link
Contributor

Nicnl commented Mar 26, 2019

Holy cow, I've linked the wrong exe

@Abu3safeer
Copy link
Contributor

Since I browse crunchyroll using Arabic layout, all my links contain /ar/, so I didn't recognize this issue at first, but later I recognize it.
image

@Abu3safeer
Copy link
Contributor

@Nicnl No problems, just link the correct one, and if you could remove the old one so if anyone tried to download the old one it will redirect him to the new one.

@aspablo
Copy link

aspablo commented Mar 26, 2019

Oh thanks @Abu3safeer and @Nicnl
Btw, now I am able to download shippuden as well. Just had to add the /ar/ or /fr/ to the url.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 26, 2019

Ok, this time I hope it'll work...
Very sorry for the inconvenience guys...

@aspablo
Copy link

aspablo commented Mar 26, 2019

@Nicnl can't actually talk against you. Cuz you are making this stuff workable. Thanks man.

@Abu3safeer
Copy link
Contributor

@Nicnl Actually I am the one who should be thankful for you, you are keeping this project alive, I really wish that I know python to help you.

This application could be more powerful that what it is.

I have even created a GUI for it using C# here:
https://github.com/Abu3safeer/anime-dl-gui

@aspablo
Copy link

aspablo commented Mar 26, 2019

@Nicnl Thanks. The new exe works. Didn't need to add the fr/ar in url either.
Thanks and good luck to you.

@Abu3safeer
Copy link
Contributor

It is working like a charm now, even without language written.
I wish @Xonshiz could respond and update this app with your patches.

@Nicnl
Copy link
Contributor

Nicnl commented Mar 26, 2019

THERE WE GO

Please note that there's still an ongoing issue I have to fix

It turns out that axipher noticed that some animes have very uncommon resolutions
For instance, Fairy Tail episode 1 is not 1920x1080..... it's 1920x1072, and it breaks everything

Downloading Fairy Tail - 02 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1072p, 240p, 360p, 480p, 720p]

And right now adding -r 1072p won't work, I need to do a few changes here and there for it to work
I'll try to fix it as soon as I have a bit of time in front of me

@Abu3safeer
Copy link
Contributor

You might do groups:
1080p = 1080p - 721p
720p = 720p - 481p
480p = 480 - 361p
360p = 360p - 0p

So the application will get all resolutions, and put them in groups, so even if the resolution is not the exact 1080p it should consider anything above 720p is 1080p.

@axipher
Copy link
Author

axipher commented Mar 27, 2019

We all appreciate the offline builds @Nicnl

Hopefully you can easily update a pull request on this main one once @Xonshiz has some time.

@Xonshiz
Copy link
Owner

Xonshiz commented May 16, 2019

This might be an issue because currently, to anime-dl isn't authenticating properly. So, the token/cookies anime-dl gets aren't authorized for HD and FHD streams. I'll take a look at this, as I am re-building anime-dl.

@axipher
Copy link
Author

axipher commented May 16, 2019

Thanks @Xonshiz if you need testing, let me know and I'm glad to help test anything.

@Xonshiz
Copy link
Owner

Xonshiz commented May 16, 2019

Sure, thanks :). Will hopefully post something in 6 hours from now.

@Nicnl
Copy link
Contributor

Nicnl commented May 16, 2019

@Xonshiz
Out of curiosity
By rebuilding, do you mean you're rewriting everything from scratch?

@axipher
Copy link
Author

axipher commented Nov 8, 2019

Still having issues on some older shows with odd resolutions, this time "Full Metal Panic" (https://www.crunchyroll.com/full-metal-panic) which has 1440x1080 as its 1080p resolution.

.\anime-dl.exe -v -i https://www.crunchyroll.com/full-metal-panic -u $username -p $password -r 1080
Trying to login...
Logged in successfully...
Total Episodes to download : 24
Downloading Full Metal Panic - 01 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1080p, 240p, 360p, 480p, 720p]
-----------------------------------------------------------


Downloading Full Metal Panic - 02 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1080p, 240p, 360p, 480p, 720p]
-----------------------------------------------------------


Downloading Full Metal Panic - 03 [1920x1080].enUS.ass ...
Could not find the requested resolution [1920x1080] in the master.m3u8 file

Here are all the available resolutions: [1080p, 240p, 360p, 480p, 720p]
-----------------------------------------------------------
#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1816763,RESOLUTION=960x720,FRAME-RATE=23.974,CODECS="avc1.64001f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=3691028,RESOLUTION=1440x1080,FRAME-RATE=23.974,CODECS="avc1.640028,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=773164,RESOLUTION=640x480,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=482427,RESOLUTION=480x360,FRAME-RATE=23.974,CODECS="avc1.4d4015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=345414,RESOLUTION=320x240,FRAME-RATE=23.974,CODECS="avc1.42c00d,mp4a.40.2"
https://a-vrv.akamaized.net/evs/xxxxxxxxxx

And this is from "Gunbuster 2" (https://www.crunchyroll.com/gunbuster-2)

When I run the command with no resolution called out, it just fails, I need to add "-r 480p" for it to correctly grab the 480p videos

#EXTM3U
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=1149128,RESOLUTION=848x480,FRAME-RATE=23.974,CODECS="avc1.4d401f,mp4a.40.2"
https://a-vrv.akamaized.net/evs/
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=613615,RESOLUTION=640x360,FRAME-RATE=23.974,CODECS="avc1.4d401e,mp4a.40.2"
https://a-vrv.akamaized.net/evs/
#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=440351,RESOLUTION=428x240,FRAME-RATE=23.974,CODECS="avc1.42c015,mp4a.40.2"
https://a-vrv.akamaized.net/evs/

@Zebraslive
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants