Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

cargo-download stdout output is truncated for some crates #10

Open
ericseppanen opened this issue Oct 2, 2021 · 2 comments · May be fixed by #11
Open

cargo-download stdout output is truncated for some crates #10

ericseppanen opened this issue Oct 2, 2021 · 2 comments · May be fixed by #11

Comments

@ericseppanen
Copy link

I'm not sure why this happens, but it reproduces every time for me:

$ wget -O file1 https://crates.io/api/v1/crates/semver/1.0.4/download
$ cargo download semver=1.0.4 >file2
$ ls -l file?
-rw-rw-r-- 1 eric eric 29375 Jul 30 10:38 file1
-rw-rw-r-- 1 eric eric 29362 Oct  1 20:54 file2

The output from cargo download is truncated by a few bytes, and tar throws errors when trying to extract it.

If I instead run cargo download -o file3 semver=1.0.4 I get the correct file contents.

@ericseppanen ericseppanen linked a pull request Oct 2, 2021 that will close this issue
@ericseppanen
Copy link
Author

I guess once I stared at the source code, the problem was obvious, and is fixed (at least for me) by #11.

There's a lot of warnings thrown off by the code on a current Rust toolchain, but it doesn't look like this code is currently maintained. Would you consider letting someone else take over maintaining this crate?

@melMass
Copy link

melMass commented May 22, 2022

@Xion it would be cool to give maintenance over if @ericseppanen is still interested

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants