forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the performance of eth_getLogs #568
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please rebase on the latest dev-upgrade branch. |
JukLee0ira
force-pushed
the
opt-getLogs
branch
2 times, most recently
from
July 2, 2024 02:31
55fa685
to
e680e9d
Compare
20 tasks
JukLee0ira
force-pushed
the
opt-getLogs
branch
11 times, most recently
from
July 4, 2024 02:18
300e89d
to
add2081
Compare
gzliudan
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gzliudan
approved these changes
Jul 9, 2024
JukLee0ira
force-pushed
the
opt-getLogs
branch
4 times, most recently
from
July 9, 2024 11:17
9a90ac8
to
f590460
Compare
JukLee0ira
changed the title
avoid unnecessary receipt processing for log filtering
use lightweight accessor for log filtering and fix deadlock issues
Jul 9, 2024
JukLee0ira
changed the title
use lightweight accessor for log filtering and fix deadlock issues
Improve the performance of log filtering
Jul 9, 2024
gzliudan
changed the title
Improve the performance of log filtering
Improve the performance of eth_getLogs
Jul 9, 2024
JukLee0ira
force-pushed
the
opt-getLogs
branch
3 times, most recently
from
July 11, 2024 05:28
a1c7160
to
398af71
Compare
gzliudan
approved these changes
Jul 11, 2024
|
||
return api | ||
} | ||
|
||
// timeoutLoop runs every 5 minutes and deletes filters that have not been recently used. | ||
// Tt is started when the api is created. | ||
func (api *PublicFilterAPI) timeoutLoop() { | ||
func (api *FilterAPI) timeoutLoop(timeout time.Duration) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new parameter timeout is not used. Please refer to: ethereum#22178
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Not all fields of a receipt are persisted to disk. Some are re-computed on read. The most expensive field to re-compute is the bloom filter which will not even be returned in
eth_getLogs
. Here we define a new decoding of receipts specifically for this use-case which avoids extra processing.Test 'eth_getLogs'
Vertical comparison
Before optimization, run the command and save the result to file1.log:
After optimization, run the same command and save the result to file2.log:
Here are their diff results:
Horizontal comparison
After the modification, sync the block data, run the command, and save the result to file3.log:
Run the command to read the log from the public RPC node and save the result to file4.log:
Here are their diff results:
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that