Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The model works with V0.9 but not with new layers in V0.10. #1055

Closed
Arbiter-glitch opened this issue Apr 23, 2024 · 2 comments
Closed

The model works with V0.9 but not with new layers in V0.10. #1055

Arbiter-glitch opened this issue Apr 23, 2024 · 2 comments
Assignees

Comments

@Arbiter-glitch
Copy link

Arbiter-glitch commented Apr 23, 2024

There is a considerable difference between the output and the expected output. Expected output is the output image received while passing the input image through the software model. I use the latest FINN branch. I trained the network outside the Finn docker. Then exported the qonnx format to Finn. Most of the nodes are rtl while some are hls.
I have included the intermediate models and the build_dataflow_steps.py in the zip file as well as the output received through finn and the expected output. The notebook for running in Pynq is also included. I don't know whether I am doing anything wrong. Also, I took out the last mul node because it just divides by 255 to get the output between 0 and 1.
check.zip

[Update:]
It works with old layers of v0.9 but not with the latest branch of FINN v0.10 with RTL layers. Since I want more throughput, RTL layers are better. But for some reason output is all white like, with some feature here and there. Hope this can be solved.
Also I have targeted ZCU104 Ultrascale+ Evaluation Board

Expected Output

expected_finn

Actual Output Received

numpy_outfinn
Originally posted by @Arbiter-glitch in #1052

@Arbiter-glitch Arbiter-glitch changed the title The model works with V9 but not with new RTL layers in V10. The model works with V0.9 but not with new RTL layers in V0.10. Apr 23, 2024
@Arbiter-glitch Arbiter-glitch changed the title The model works with V0.9 but not with new RTL layers in V0.10. The model works with V0.9 but not with new layers in V0.10. Apr 24, 2024
@Arbiter-glitch
Copy link
Author

Arbiter-glitch commented Apr 30, 2024

[Update]:

To find out why the output is different in finn v0.10. I took Finn v0.9 and started to replace each of the old layers with new RTL layers, I checked at each stage. And it was only after replacing the old Thresholding hls layers with RTL layers, the output varied from the expected to give the white one again. So the problem might be with the thresholding rtl layers.

@azizb-xlnx azizb-xlnx self-assigned this May 3, 2024
@auphelia
Copy link
Collaborator

See: Issue #1060 and PR #1077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants