Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

Compilation error on clang-10 #802

Closed
neverchanje opened this issue Mar 26, 2021 · 0 comments · Fixed by #803
Closed

Compilation error on clang-10 #802

neverchanje opened this issue Mar 26, 2021 · 0 comments · Fixed by #803

Comments

@neverchanje
Copy link
Contributor

neverchanje commented Mar 26, 2021

root/pegasus/rdsn/src/meta/test/meta_bulk_load_service_test.cpp:213:33: error: loop variable 'kv' of type 'const std::pair<const int, dsn::replication::partition_bulk_load_info>' creates a copy from type 'const std::pair<const int, dsn::replication::partition_bulk_load_info>' [-Werror,-Wrange-loop-construct]
                for (const auto kv : partition_bulk_load_info_map) {
                                ^
/root/pegasus/rdsn/src/meta/test/meta_bulk_load_service_test.cpp:213:22: note: use reference type 'const std::pair<const int, dsn::replication::partition_bulk_load_info> &' to prevent copying
                for (const auto kv : partition_bulk_load_info_map) {
                     ^~~~~~~~~~~~~~~
                                &
/root/pegasus/rdsn/src/meta/test/meta_bulk_load_service_test.cpp:283:25: error: loop variable 'kv' of type 'const std::pair<const dsn::gpid, dsn::replication::partition_bulk_load_info>' creates a copy from type 'const std::pair<const dsn::gpid, dsn::replication::partition_bulk_load_info>' [-Werror,-Wrange-loop-construct]
        for (const auto kv : bulk_svc()._partition_bulk_load_info) {
                        ^
/root/pegasus/rdsn/src/meta/test/meta_bulk_load_service_test.cpp:283:14: note: use reference type 'const std::pair<const dsn::gpid, dsn::replication::partition_bulk_load_info> &' to prevent copying
        for (const auto kv : bulk_svc()._partition_bulk_load_info) {
             ^~~~~~~~~~~~~~~
                        &
/root/pegasus/rdsn/src/http/pprof_http_service.cpp:477:27: error: object backing the pointer will be destroyed at the end of the full-expression [-Werror,-Wdangling-gsl]
    const char *req_url = req.full_url.to_string().data();
                          ^~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
src/http/CMakeFiles/dsn_http.dir/build.make:146: recipe for target 'src/http/CMakeFiles/dsn_http.dir/pprof_http_service.cpp.o' failed
make[2]: *** [src/http/CMakeFiles/dsn_http.dir/pprof_http_service.cpp.o] Error 1
/root/pegasus/rdsn/thirdparty/output/include/Poco/Dynamic/VarHolder.h:409:14: error: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-int-float-conversion]
                if (from > std::numeric_limits<T>::max())
                         ~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/pegasus/rdsn/thirdparty/output/include/Poco/Dynamic/VarHolder.h:313:4: note: in instantiation of function template specialization 'Poco::Dynamic::VarHolder::checkUpperLimitFloat<float, int>' requested here
                        checkUpperLimitFloat<F,T>(from); 
In file included from /root/pegasus/rdsn/src/runtime/security/kinit_context.cpp:23:
/root/pegasus/rdsn/thirdparty/output/include/krb5/krb5.h:3566:19: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
                  register char **name);
                  ^~~~~~~~~
/root/pegasus/rdsn/thirdparty/output/include/krb5/krb5.h:4389:21: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
                    register krb5_const_principal pr, krb5_data *ret);
/root/pegasus/rdsn/src/replica/backup/cold_backup_context.h:74:1: error: 'cold_backup_metadata' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
struct cold_backup_metadata
^
/root/pegasus/rdsn/src/replica/replica.h:75:1: note: did you mean struct here?
class cold_backup_metadata;
^~~~~
struct
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant