Only copy strings once #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/patch-string-view-4
branch
from
1a882ab
to
eb1c29a
Compare
alamb
commented
Jul 8, 2024
| @@ -641,8 +643,9 @@ impl ByteViewArrayDecoderDelta { | |||
| if bytes.len() > 12 { | |||
| // only copy the data to buffer if the string can not be inlined. | |||
| array_buffer.extend_from_slice(bytes); | |||
| } else { | |||
| utf8_validation_buffer.extend_from_slice(bytes); | |||
There was a problem hiding this comment.
this only copies the strings once (but then we have to call validate twice on the two different buffers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this targets apache#6004
I think this might be faster because it only copies strings once. Perhaps this is being overly obsessive, but since we are down here anyways let's obsess