Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 11 Startup loop. Not working in upstream as well. #3

Closed
kubo6472 opened this issue Apr 18, 2021 · 19 comments
Closed

Android 11 Startup loop. Not working in upstream as well. #3

kubo6472 opened this issue Apr 18, 2021 · 19 comments
Labels
bug Something isn't working

Comments

@kubo6472
Copy link
Contributor

Screen recording the bug caused this issue to reset.
I tested the original app. Still the same thing.

Screen_Recording_20210418-103634_NewPipe.preunified.mp4

here's what happens when I click on any YouTube link in other apps and newpipe preunified is the default app to open. As per beginning this must be device specific.
I use only preunified, so I'd love if the fix I'm about to propose to upstream will be backported. I'll try my best testing and making some PR from the code.

@SpazMahTazz
Copy link

SpazMahTazz commented May 6, 2021

I get this issue in v0.21.2 running android 8.1

@kubo6472

This comment has been minimized.

@SpazMahTazz
Copy link

I get this issue in v0.21.2 running android 8.1

What is your phone by any chance?

Blackberry keyone, my samsung galaxy tab a 10.5 on android 11 does it too. 0.21.0 works fine on both.

@kubo6472

This comment has been minimized.

@kubo6472

This comment has been minimized.

@kubo6472
Copy link
Contributor Author

kubo6472 commented May 7, 2021

Tested, that it happened between the 0.21.0 and .1 and contrary to the main app, the newest extractor doesn't fix the issue. For now I'm sticking to using the old extractor.

@XiangRongLin
Copy link
Owner

@kubo6472 Do you know by chance which of the commits in #6053 fixed this? Then i can try to cherry pick it here

@kubo6472

This comment has been minimized.

@XiangRongLin
Copy link
Owner

@kubo6472 Can you test this?

app-release.zip

@SpazMahTazz
Copy link

@kubo6472 Can you test this?

app-release.zip

Just gave it a whirl on the keyone and it still spazzes out like OP's vid when clicking on a yt link.

@kubo6472

This comment has been minimized.

@XiangRongLin
Copy link
Owner

app-debug.zip
Welp, it would have made sense to actually look at the logs and go from there, since i have android 11 too...

@XiangRongLin
Copy link
Owner

Fixed with 526bd59 and caaceb9

@SpazMahTazz
Copy link

Hate to be a downer, but I still get this issue on v0.21.2.1 with the keyone.

@XiangRongLin
Copy link
Owner

Hmm...

Im pretty sure it's occuring because of the the ErrorInfo change to use the Parcelize annotation. While displaying the error screen, it throws a new one, which causes the loop.
I pretty sure it's this because there was the same issue in the main repo, which i thought was was solved by the commit i cherry picked.

@XiangRongLin XiangRongLin reopened this May 19, 2021
@SpazMahTazz
Copy link

Well if you need me to do any testing just let me know. That's about all I can do.

@XiangRongLin
Copy link
Owner

app-release.zip
I feel like i either uploaded the wrong app or generated it from old sources.

@SpazMahTazz
Copy link

I can open YouTube links with that apk, thanks!

@kubo6472

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants