Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Rate returns None for Accounting: Bank transactions API when it shows correct value on Xero API Explorer #129

Open
jessiejc23 opened this issue Apr 19, 2024 · 2 comments

Comments

@jessiejc23
Copy link

Issue Description:
When using the Xero API Explorer - Accounting API > Bank Transactions, the response returns the expected currency rate. However, when using get_bank_transactions API endpoint, the response returns None for currency rate. This happens to only selected seemingly random cases.

Steps to Reproduce:

  1. On Xero API Explorer > Accounting > Bank Transactions, compare the currency_rate for selected period of bank transactions
  2. Make a call to the get_bank_transactions endpoint with the required parameters (e.g., xero_tenant_id, xero_status, page, page_size).
  3. Inspect the response for currency_rate.

Expected Behavior:
The get_bank_transactions API response should include the correct currency rate as displayed on Xero API Explorer.

Actual Behavior:
The get_bank_transactions API response returns None for currency rate.

API Call:
xero_bank_txn = accounting_api.get_bank_transactions(xero_tenant_id, page)

Sample Output:

{
  ...
  'bank_transaction_id': 'x'xx,
   'contact': None,
   'currency_code': <CurrencyCode.USD: 'USD'>,
   'currency_rate': None,
   'date': datetime.date(2022, 12, 6),
  ...
}

Screenshot:
Xero API Explorer response (expected)
Screenshot 2024-04-19 at 21 12 30

get_bank_transactions response (actual)
Screenshot 2024-04-19 at 21 12 44

Copy link

PETOSS-413

Copy link

Thanks for raising an issue, a ticket has been created to track your request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant