From 37bbe4a18603a23e06c8ffd50b695ad2fce66fb4 Mon Sep 17 00:00:00 2001
From: sangeet-joy_xero <sangeet.joy@xero.com>
Date: Wed, 16 Oct 2024 15:06:11 +0530
Subject: [PATCH] testing

---
 .github/actions/notify-slack/action.yml | 10 +++-------
 .github/workflows/publish.yml           |  5 +----
 2 files changed, 4 insertions(+), 11 deletions(-)

diff --git a/.github/actions/notify-slack/action.yml b/.github/actions/notify-slack/action.yml
index efda7ea9..0f91a4f6 100644
--- a/.github/actions/notify-slack/action.yml
+++ b/.github/actions/notify-slack/action.yml
@@ -4,16 +4,13 @@ description: "Action to send slack payload to public-sdk-events channel"
 inputs:
   heading_text:
     required: true
-    description: "test"
+    description: "Heading of the slack payload"
   alert_type:
     required: true
-    description: "test"
+    description: "type of the slack alert"
   job_status:
     required: true
-    description: "test"
-  job_url:
-    required: true
-    description: "test"
+    description: "status of the job"
 
 runs:
   using: "composite"
@@ -27,7 +24,6 @@ runs:
          echo ${{inputs.job_status}}
          echo ${{github.repository}}
          echo ${{github.sha}}
-         echo ${{inputs.job_url}}
 
     # - name: Send slack notification
     #   id: slack
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 1f97bd32..c413b976 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -49,14 +49,12 @@ jobs:
           repository: XeroAPI/xero-node
           path: xero-node
 
-
       - name: Send slack notification on success
         uses: ./xero-node/.github/actions/notify-slack
         with:
          heading_text: "Publish job has succeeded !"
          alert_type: "good"
          job_status: ${{job.status}}
-         job_url: "https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}"
 
   notify-slack-on-failure:
     runs-on: ubuntu-latest
@@ -72,7 +70,6 @@ jobs:
       - name: Send slack notification on failure
         uses: ./xero-node/.github/actions/notify-slack
         with:
-          heading_text: "Publish job has failed, Please check the logs"
+          heading_text: "Publish job has failed. Check the details here: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}"
           alert_type: "danger"
           job_status: ${{job.status}}
-          job_url: "https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}"