#280 configuration for selenide messages #281
Conversation
There was a problem hiding this comment.
I think it is better to set the showSelenideErrorDetails property to true in testErrorDetailesActived and to false in testErrorDetailesDeActived and I would change the name of the tests (Actived to Activated).
There was a problem hiding this comment.
fair enough, changed it
There was a problem hiding this comment.
required to make it work, therefore, should stay
There was a problem hiding this comment.
Looks like it's really not required here. Please, remove
There was a problem hiding this comment.
Looks like it's really not required here. Please, remove
|
|
||
| if (Neodymium.configuration().showSelenideErrorDetails()) | ||
| { | ||
| return Strings.join(super.generateErrorDetails(error, driver, screenshot, timeoutMs)); |
There was a problem hiding this comment.
return value is a string, so we probably don't need Strings.join here
There was a problem hiding this comment.
correct. removed it.
| StringBuilder sb = new StringBuilder(); | ||
| return sb.append("(") | ||
| .append(timeout(timeoutMs)) | ||
| .append(")") | ||
| .toString(); |
There was a problem hiding this comment.
can we reuse the functionality Selenide offers?
| StringBuilder sb = new StringBuilder(); | |
| return sb.append("(") | |
| .append(timeout(timeoutMs)) | |
| .append(")") | |
| .toString(); | |
| return join("(" + timeout(timeoutMs) + ")"); |
or maybe with cause (because sometimes SERE may appear in cause instead of actual message and it may be useful to know that the exception was cause by SERE)
| StringBuilder sb = new StringBuilder(); | |
| return sb.append("(") | |
| .append(timeout(timeoutMs)) | |
| .append(")") | |
| .toString(); | |
| return join("(" + timeout(timeoutMs) + ")", causedBy(error.getCause())); |
There was a problem hiding this comment.
as agreed in the call, we keep the stringbuilder as is
There was a problem hiding this comment.
required to make it work, therefore, should stay
No description provided.