Fixes a bug where backend_options would be passed to backends that don't support it.
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 99.34% 99.35% +<.01%
==========================================
Files 8 8
Lines 307 311 +4
==========================================
+ Hits 305 309 +4
Misses 2 2
Continue to review full report at Codecov.
|
josh146
changed the title
backend_options would be passed to backends that don't support it.backend_options would be passed to backends that don't support it.
josh146
changed the title
backend_options would be passed to backends that don't support it.backend_options would be passed to backends that don't support it.
co9olguy
approved these changes
Sep 14, 2019
| super().__init__(wires, qiskit.Aer, backend=backend, shots=shots, **kwargs) | ||
| self._noise_model = noise_model | ||
|
|
||
| def run(self, qobj): |
There was a problem hiding this comment.
I noticed that this was part of the same bug. There were no tests for noise models, so it wasn't picked up. Since the logic for kwargs is now part of the base class, this method is redundant and can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: The current
QiskitDeviceassumes that all backends accept backend options, but this isn't the case --- hardware backends on IBMQ do not accept backend options. This leads to anTypeErrorfor hardware-bound jobs.Description of change:
inspect.signatureis used to determine what keyword arguments the backend supports.A new attribute
self.run_argsis now used to correctly store a dictionary of allowed keyword arguments.Version number incrementation for a minor bugfix release.
Benefits: Fixes the bug
GitHub Issues: https://discuss.pennylane.ai/t/pennylane-qiskit-error/204