-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin cleanup and refactor #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 92.35% 96.96% +4.61%
==========================================
Files 6 8 +2
Lines 301 264 -37
==========================================
- Hits 278 256 -22
+ Misses 23 8 -15
Continue to review full report at Codecov.
|
This was referenced Aug 5, 2019
Closed
quantshah
approved these changes
Aug 5, 2019
I made some small comments on typos. I could update them myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is quite a significant clean up and refactor of the plugin. In particular,
All code blocks not being used were removed
Superfluous conditionals were deleted
Unused methods and attributes were deleted
Documentation and licenses were updated to bring them up to standard
Long and confusing names were shorted
device.py
was split into separate files, one per deviceThe long standing IBM Q bug (see Bug: Missing url for qiskit #38 and added ibmqx_url as additional option to IBMQiskitDevice #39) was fixed, and the IBM Q device now supports both v1 and v2 of the IBM API
The deprecated custom gates in
qiskitops.py
were removed, and replaced with the recommended approach to defining Qiskit custom gates.To-do: None of the tests were refactored, this is still on the todo list.