Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin cleanup and refactor #44

Merged
merged 8 commits into from
Aug 6, 2019
Merged

Plugin cleanup and refactor #44

merged 8 commits into from
Aug 6, 2019

Conversation

josh146
Copy link
Member

@josh146 josh146 commented Aug 4, 2019

Description of changes:

This is quite a significant clean up and refactor of the plugin. In particular,

  • All code blocks not being used were removed

  • Superfluous conditionals were deleted

  • Unused methods and attributes were deleted

  • Documentation and licenses were updated to bring them up to standard

  • Long and confusing names were shorted

  • device.py was split into separate files, one per device

  • The long standing IBM Q bug (see Bug: Missing url for qiskit #38 and added ibmqx_url as additional option to IBMQiskitDevice #39) was fixed, and the IBM Q device now supports both v1 and v2 of the IBM API

  • The deprecated custom gates in qiskitops.py were removed, and replaced with the recommended approach to defining Qiskit custom gates.

To-do: None of the tests were refactored, this is still on the todo list.

@josh146 josh146 requested a review from quantshah August 4, 2019 16:59
@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #44 into master will increase coverage by 4.61%.
The diff coverage is 96.68%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   92.35%   96.96%   +4.61%     
==========================================
  Files           6        8       +2     
  Lines         301      264      -37     
==========================================
- Hits          278      256      -22     
+ Misses         23        8      -15
Impacted Files Coverage Δ
pennylane_qiskit/_version.py 100% <100%> (ø) ⬆️
pennylane_qiskit/aer.py 100% <100%> (ø)
pennylane_qiskit/ops.py 100% <100%> (ø) ⬆️
pennylane_qiskit/__init__.py 100% <100%> (ø) ⬆️
pennylane_qiskit/basic_aer.py 100% <100%> (ø)
pennylane_qiskit/ibmq.py 85.18% <85.18%> (ø)
pennylane_qiskit/gates.py 93.47% <93.47%> (ø)
pennylane_qiskit/qiskit_device.py 99.2% <99.2%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df98ed9...bf86864. Read the comment docs.

.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
pennylane_qiskit/aer.py Outdated Show resolved Hide resolved
pennylane_qiskit/aer.py Outdated Show resolved Hide resolved
pennylane_qiskit/gates.py Outdated Show resolved Hide resolved
@quantshah
Copy link
Contributor

I made some small comments on typos. I could update them myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants