-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External dependency nlohmann/json.hpp
fails to build under Intel compiler icpc with warnings as error
#9
Comments
Nice catch! Given that the library is under an MIT license, I think we are allowed to fix these errors in our copy of the header. |
Weird I haven't had any problem running the serializer on niagara with the intel compiler, but I usually compile with a one-liner command. I will take more of a look. |
Does your build enable warnings as errors? This could also be tied to the version of the Intel compiler I am using, as I did not test it with others available on the system. |
This may be a good idea. Any thoughts on whether we just fix it locally, or consider creating a PR against the repo? |
Ideally, we should do both; however, our first priority is fixing the copy in the Jet repository. |
Just a note on this, Intel is phasing out the icc compiler in favour of the newer LLVM-backed compiler (icx), and requests all users to port to the newer suite. This issue can likely be ignored when the classica compiler is no longer supported. |
Expected behavior: The external library
nlohmann/json.hpp
should compile and link without any modifications required.Actual behavior: Compiling with the classic intel compiler (icpc) causes several errors to be reported (see below).
Reproduces how often: Only when building with icpc (2021.2.0 20210228) on Niagara.
System information: Niagara HPC system, using the Jet benchmark for the TBCC.
Source code and backtraces
Please include any additional code snippets and backtraces related to the issue here.
Additional information
Any additional information, configuration or data that might be necessary to reproduce the issue.
The Jet benchmark
Jet_TBCC
was built and failed with the commands:and succeeded with
The text was updated successfully, but these errors were encountered: