New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type for a sum : Int -> unsigned int #21

Open

rubeecube opened this issue Oct 2, 2023 · 0 comments

rubeecube commented Oct 2, 2023 •

edited

Loading

Hi

In the following code:
https://github.com/XMSS/xmss-reference/blob/171ccbd26f098542a67eb5d2b128281c80bd71a6/wots.c#L85C5-L85C5

The types of variables for the following contains both signed and unsigned int:

params->wots_w: unsigned int
csum: int
msg_base_w: const int*

This might cause issues in corner cases.

Should csum / msg_base_w be unsigned?
Should csum be verified to be positive before the bitshift?

rubeecube mentioned this issue

Change lengths/sums to unsigned variables. #22

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment