Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for passing arguments to commands #8

Open
PatrickLehnerXI opened this issue Dec 28, 2020 · 1 comment
Open

Add integration tests for passing arguments to commands #8

PatrickLehnerXI opened this issue Dec 28, 2020 · 1 comment

Comments

@PatrickLehnerXI
Copy link
Contributor

The issues found and fixed in #5 showed that passing arguments to commands isn't trivial, and especially may behave differently between OSs.

We should add some test coverage (at least in the integration tests, but maybe also unit tests?) to make sure that running commands with arguments does work, esp. the non-trivial cases (such as arguments containing spaces, containing quotes, containing backslashes).

@PatrickLehnerXI
Copy link
Contributor Author

These test should generally try covering all public functions provided by devcmd.

For example, when adding the execToString and execInTty functions, there was a bug that the methods in ProcessExecutor weren't properly bound, which wasn't caught by the existing tests at the time. (See c24b4f8 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant