Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does octocrab v0.20.0 support rustls? #341

Closed
koyashiro opened this issue Apr 17, 2023 · 2 comments
Closed

Does octocrab v0.20.0 support rustls? #341

koyashiro opened this issue Apr 17, 2023 · 2 comments

Comments

@koyashiro
Copy link

In v0.20.0 reqwest has been replaced by http, hyper and tower, but the rustls features flag that was present before seems to have been removed.

Has rustls support been removed?
@XAMPPRocky
Copy link
Owner

Thank you for your issue! I may be wrong but I believe the old feature wasn't relevant anymore with the removal of reqwest, users should be able to provide their own HTTP client with whatever TLS implementation they prefer.

@koyashiro
Copy link
Author

I appreciate your prompt reply.

By referring to examples/custom_client.rs, my problem was solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XAMPPRocky @koyashiro