feat: move the geocoding control to a separate library #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eschricker Thanks for the PR! I'll try to take a look later this week. |
dmytro-gokun
force-pushed
the
feature/geocoding-in-own-project
branch
from
9eaf222
to
4330ee5
Compare
dmytro-gokun
changed the title
Nosfit
pushed a commit
to Nosfit/ngx-mapbox-gl
that referenced
this pull request
Jun 22, 2021
Co-authored-by: Dmytro Gokun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In advance: I am not very experienced in creating angular projects, but I did my best. Feedback is welcome.
I moved the geocoding control into its own project and therefore in it's own module. As a result the dependency to @mapbox/mapbox-gl-geocoder is moved too. This feature was called in #262 .
The library was generated by using
ng generate library ngx-mapbox-gl-geocoder-control