Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified version number results in constant connect + disconnect cycle #134

Open
LordofSandvich opened this issue Nov 15, 2017 · 8 comments

Comments

@LordofSandvich
Copy link

It works fine if the version numbers match but it does not intelligently avoid matching with players whose version number does not match, resulting in occasional lagspikes from the constant connect and disconnect loop. Most noticeable in places already performance-intensive such as Blighttown.

@Chronial
Copy link
Collaborator

So you modified the version number of your dark souls client?

@LordofSandvich
Copy link
Author

LordofSandvich commented Nov 15, 2017

Someone did it for me, I don't know any code myself. From what I remember you have to rewrite three locations in the Dark Souls .exe which is best done through a DLL.

@Chronial
Copy link
Collaborator

Why would you do that? If you did that, your darksouls is not supported by DSCM. Please do not join DSCM-Net if you changed your version.

@LordofSandvich
Copy link
Author

There are two overhauls which are using modified version numbers in order to function within online play but separate from the main vanilla playerbase. This way players are not invaded by opponents with modified stats and equipment, or worse, have access to invisible spells.

Consider this issue a request.

@Wulf2k
Copy link
Owner

Wulf2k commented Nov 15, 2017

There's no reason to use DSCM-Net with a modified Dark Souls. Just use the Connect by Steam ID feature.

If you get a large enough playerbase the DSCM-Net code is available to launch your own server.

It may be worth making it easier to change the server address in DSCM at some point.

@Chronial
Copy link
Collaborator

We should probably detect changed version numbers and force-disable DSCM-Net.

@LordofSandvich DSCM should never go into a "constant connect and disconnect loop". I don't think the performance issues you are having are caused by DSCM.

@metal-crow
Copy link

I agree that having a separate server for each overhaul is a good idea, but is a separate client also necessary? I'd be open to making a PR that has DSCM support multiple servers, and it auto-chooses which one to use based on dark souls version number.

@LordofSandvich
Copy link
Author

Could you DM me what I need to know to set up a server, Wulf? Doesn't need to be massively technical but I'd like to know what I or someone else needs to do for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants