Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager Support #128

Open
fred-bowker opened this issue Jun 13, 2024 · 7 comments
Open

Swift Package Manager Support #128

fred-bowker opened this issue Jun 13, 2024 · 7 comments
Assignees

Comments

@fred-bowker
Copy link

There is an issue ticket for this but it is closed #122
Can we add the Swift Package manager support I don't see any Packages.swift. If you're ok with adding this, I'm happy to put in a pull request for this.

Cheers for creating StompClientLib

@teendream
Copy link

@fred-bowker great idea, looking for this!

@WrathChaos WrathChaos self-assigned this Jul 25, 2024
@WrathChaos
Copy link
Owner

Hey @fred-bowker
Thank you so much for the contribution. If you can create a PR for it, it would be awesome.

@teendream
Copy link

Hi @fred-bowker @WrathChaos any updates?

@teendream
Copy link

Hi @WrathChaos can you review #130 , please?

@WrathChaos
Copy link
Owner

Hi @teendream
There are too many changes in your PR, please take a look at it

@fred-bowker
Copy link
Author

@WrathChaos Hi, it looks like @teendream is looking into implementing the swift package manager support, if it is not done by the end of August, I'll do the change and put up a pull request, cheers Fred

@teendream
Copy link

teendream commented Aug 1, 2024

@fred-bowker yes I need spm implementation, I forked it and experimenting it. So I'm in the stage where I need add SocketRocket as dependency to the StompClient. But SocketRocket also does not have SPM implementation, so I'm wrapping it too. Problems with headers in objc. Would be great if somebody helps me with direction where I need to dig. Thanks beforehand.

fatal error: 'NSRunLoop+SRWebSocketPrivate.h' file not found
#import "NSRunLoop+SRWebSocketPrivate.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fatal error: 'NSURLRequest+SRWebSocketPrivate.h' file not found
#import "NSURLRequest+SRWebSocketPrivate.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 let package = Package(
    name: "SocketRocket",
    platforms: [.iOS(.v12)],
    products: [
        .library(
            name: "SocketRocket",
            targets: ["SocketRocket"]
        ),
    ],
    targets: [
        .target(
            name: "SocketRocket",
            path: "SocketRocket",
            publicHeadersPath: "include"
        ),
        .testTarget(
            name: "SocketRocketTests",
            dependencies: ["SocketRocket"]
        ),
    ],
    cLanguageStandard: .c11,
    cxxLanguageStandard: .cxx11
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants