Draw call batching for Paths #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 14, 2024 10:28
…eShape, TODO recreate buffer if color or lineWidth changes in standard shapes, preallocate pickmode id
…nges to shapes, rename StaticPath to LinesBatch
…lity in PathPolygonsLabelsActivity
…r highways in PathPolygonsLabesActivity
…y, override doRender method for LinesBatch
…ble and batch them as needed
…when Path became batchable after some changes
…setColor to offset pickColor inside lineSet (not working as expected, proper lines not selected)
…o batches in RenderableLayer
… been changed, added texturing to lines batch
.../src/commonMain/kotlin/earth/worldwind/shape/milstd2525/AbstractMilStd2525TacticalGraphic.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/earth/worldwind/shape/milstd2525/AbstractMilStd2525TacticalGraphic.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/layer/RenderableLayer.kt
Outdated
Show resolved
Hide resolved
worldwind/src/commonMain/kotlin/earth/worldwind/render/VertexState.kt
Outdated
Show resolved
Hide resolved
| @@ -9,31 +9,46 @@ import earth.worldwind.util.kgl.KglUniformLocation | |||
| open class TriangleShaderProgram : AbstractShaderProgram() { | |||
| override var programSources = arrayOf( | |||
| """ | |||
| #version 300 es | |||
There was a problem hiding this comment.
Should we add ES 3.0 declaration in Android manifest also? Or we already have it there?
There was a problem hiding this comment.
just use it for this file. We will need to rewrite all other shaders if this will be added to manifest, probably should be done in separate pr if ever
| @@ -44,14 +45,36 @@ abstract class AbstractShape(override var attributes: ShapeAttributes): Abstract | |||
| override var highlightAttributes: ShapeAttributes? = null | |||
| override var isHighlighted = false | |||
| var maximumIntermediatePoints = 10 | |||
| protected lateinit var activeAttributes: ShapeAttributes | |||
| protected var isSurfaceShape = false | |||
| lateinit var activeAttributes: ShapeAttributes | |||
There was a problem hiding this comment.
Do we still need to have it public?
There was a problem hiding this comment.
Yes, still used in PathSet to get attributes
| protected var isSurfaceShape = false | ||
| lateinit var activeAttributes: ShapeAttributes | ||
| protected set | ||
| var isSurfaceShape = false |
There was a problem hiding this comment.
Smae here. Do we still need to hava it public?
There was a problem hiding this comment.
Yes, still used in PathSet to get attributes
| var lastRequestedFrameIndex = 0L | ||
|
|
||
| open fun addToBatch(rc : RenderContext) : Boolean { | ||
| return rc.currentLayer is RenderableLayer && allowBatching && !isHighlighted |
There was a problem hiding this comment.
In case of Graticule it will not b a renderable layer. Can we remove this cast check?
There was a problem hiding this comment.
Added TODO comment, better to address that in another PR with more testing
ComBatVision
requested changes
Oct 14, 2024
ComBatVision
force-pushed
the
develop
branch
5 times, most recently
from
5811728
to
cfa9e03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.