Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component doesn't work in conjuction with the Fullscreen API #891

Closed
zinas opened this issue Oct 22, 2020 · 1 comment · Fixed by #1403
Closed

Select component doesn't work in conjuction with the Fullscreen API #891

zinas opened this issue Oct 22, 2020 · 1 comment · Fixed by #1403
Labels
bug Something isn't working

Comments

@zinas
Copy link

zinas commented Oct 22, 2020

🐛 Bug Report

We are using the Select component inside the Workday Media widget. When we make the video go fullscreen, the Select components no longer work: when you click on them, the list of options doesn't appear. The reason this happens is because the list of options is appended to the body, while fullscreen is requested on a different element. This means that the stacking order of the options is lower than anything inside the fullscreen element and thus they wont appear

To Reproduce

The code I mentioned is not yet merged, so I can't link to it. But you can reproduce by having a very simple page and requesting fullscreen on any element

Expected Behavior

List of choices of the Select component appears

Actual Results

As described in the first paragraph

Browser (if applicable)

It applies to every browser

Link to repl or repo (highly encouraged)

Please provide a reference to a repo or branch to help us reproduce this bug.

Error Output

Paste the error output here

or

Include a screenshot of a visual bug

@zinas zinas added the bug Something isn't working label Oct 22, 2020
@zinas
Copy link
Author

zinas commented Oct 22, 2020

Potential solution would be to be able to define a containerElement for the component

@lychyi lychyi added question Further information is requested p:2 and removed question Further information is requested labels Oct 26, 2020
@NicholasBoll NicholasBoll linked a pull request Jan 3, 2022 that will close this issue
@jaclynjessup jaclynjessup moved this to ✅ Done in Canvas Kit Aug 2, 2022
@jaclynjessup jaclynjessup removed the p:2 label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants