Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default remove string for Removeable pill #2968

Open
mannycarrera4 opened this issue Oct 8, 2024 · 0 comments
Open

Remove default remove string for Removeable pill #2968

mannycarrera4 opened this issue Oct 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mannycarrera4
Copy link
Contributor

🐛 Bug Report

We should remove ariaLabel="remove" from the removeable pill and add aria-label="Remove" to our examples where we use Pill.IconButton in our example so that it's obvious that users should provide an aria label. We should never use english words built in to the components.

https://github.com/Workday/canvas-kit/blob/master/modules/preview-react/pill/lib/PillIconButton.tsx#L75
@mannycarrera4 mannycarrera4 added the bug Something isn't working label Oct 8, 2024
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Canvas Kit
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mannycarrera4