Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaginationButton focus should be themable #2940

Closed
mannycarrera4 opened this issue Oct 2, 2024 · 1 comment
Closed

PaginationButton focus should be themable #2940

mannycarrera4 opened this issue Oct 2, 2024 · 1 comment
Labels
10.x bug Something isn't working

Comments

@mannycarrera4
Copy link
Contributor

mannycarrera4 commented Oct 2, 2024 •
edited
Loading

🐛 Bug Report

Currently, the canvas provider theme does not theme pagination button correctly. Here's a sandbox demonstrating the issue.
@mannycarrera4 mannycarrera4 added bug Something isn't working 10.x labels Oct 2, 2024
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Oct 2, 2024
@NicholasBoll
Copy link
Member

The PaginationButton focus is themable, but it themes based on primary brand color rather than the focus color.

canvas-kit/modules/react/button/lib/BaseButton.tsx

Line 192 in 0c48e7e

cssVar(boxShadowOuter, brand.primary.base)

The brand color used here should be brand.common.focusOutline instead of branch.primary.base.

@josh-bagwell josh-bagwell mentioned this issue Oct 2, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Canvas Kit Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
10.x bug Something isn't working
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NicholasBoll @mannycarrera4