Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit custom styles vs theme.json #40

Open
iandunn opened this issue Oct 1, 2021 · 4 comments
Open

Audit custom styles vs theme.json #40

iandunn opened this issue Oct 1, 2021 · 4 comments
Labels
Help Wanted Extra attention is needed [Type] Developer Experience [Type] Enhancement New feature or request

Comments

@iandunn
Copy link
Member

iandunn commented Oct 1, 2021

As we learn more about theme.json, I have the feeling that we'll notice areas where we've added custom CSS directly to the theme unnecessarily.

My impression is that theme.json should be able to remove the need for ~70% of the typical custom CSS, but I'm also skeptical that it works out that way in real life. It'd be awesome to be proven wrong, though.

This applies to the header/footer block as well.

@iandunn iandunn added the [Type] Enhancement New feature or request label Oct 1, 2021
@iandunn iandunn added this to the Initial Launch milestone Oct 1, 2021
@tellyworth tellyworth added the Help Wanted Extra attention is needed label Oct 18, 2021
@tellyworth
Copy link
Contributor

@kellychoffman @beafialho might have some advice (or is this more a Theme Team thing?)

@iandunn
Copy link
Member Author

iandunn commented Oct 22, 2021

These milestones are where we're tracking issues that are best for the design team:

...and these ones are best for the theme team:

@iandunn
Copy link
Member Author

iandunn commented Mar 8, 2022

Related WordPress/gutenberg#38694

@iandunn
Copy link
Member Author

iandunn commented Apr 13, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed [Type] Developer Experience [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants