-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected error when exporting to Github #1367
Comments
Hi @henriqueiamarino, I am planning to look at this later today. |
I have not yet been able to reproduce this issue. I was able to successfully create a PR for a readme change to upsidedown: @henriqueiamarino would it be possible for you to export a zip of your upsidedown changes within Playground and add it to this issue? That way, we can try creating a PR with your exact changes. |
Hey @brandonpayton, thanks for your help. If I try Learn more about troubleshooting WordPress, I get this: If I choose to go default with Storage type: None, the page refreshes as I try to export to GitHub, and I lose all my work. I don't know if it is related to permissions or anything else, but I can't use it anymore. |
Here is the zip file to replace the current theme on the PR if you would like to create it yourself. |
Browser storage-wise, I'm very aware. Solving this problem will open a lot of doors for Playground and I want to get it going soon. It's the same conundrum as running Blueprints on an existing WordPress instance. |
@henriqueiamarino, thank you for the zip of the theme changes. It's nice to have that. Unfortunately, I still haven't been able to reproduce the issue. A couple things might help us move forward here:
|
@brandonpayton it is awkward! We should be able to automate the export / import process and get rid of that modal. If we get another domain name, we should also be able to store GitHub token for later and ditch the requirement of connecting to GitHub every single time – right now it's all the same site and there's no way of persisting the GitHub token without exposing it to the embedded Playground. |
@brandonpayton, replying to this:
The current menu option, Export Pull Request to GitHub, can be confusing for users. I propose changing it to Connect your GitHub account or having a Connect option active on top of a disabled Export to address this issue.
As we work in very different time zones, I'll record a video of my tests and share it with you soon. Thanks. |
Hey @brandonpayton, as I mentioned, here's my screen recording of the errors mentioned. |
Related issue #1334 |
…stream repo isn't allowed When the GitHub export flow used a forked repository, it would still attempt to create a branch in the upstream repository. This resulted in the following cryptic error: > There was an unexpected error (Not Found), please try again. If the > problem persists, please report it at https://github.com/WordPress/ > wordpress-playground/issues. This PR ensures that branch is created in the push target ## Testing instructions 1. Import an `upsidedown` theme from https://github.com/Automattic/themes 2. Run `await playground.writeFile('/wordpress/wp-content/themes/upsidedown/test.txt', 'test');` in devtools 3. Try to export the changes as a PR, confirm a PR got created Closes #1367
#1392 might fix it 🤞 |
…stream repo isn't allowed (#1392) When the GitHub export flow used a forked repository, it would still attempt to create a branch in the upstream repository. This resulted in the following cryptic error: > There was an unexpected error (Not Found), please try again. If the > problem persists, please report it at https://github.com/WordPress/ > wordpress-playground/issues. This PR ensures that branch is created in the push target ## Testing instructions 1. Import an `upsidedown` theme from https://github.com/Automattic/themes 2. Run `await playground.writeFile('/wordpress/wp-content/themes/upsidedown/test.txt', 'test');` in devtools 3. Try to export the changes as a PR, confirm a PR got created Closes #1367
I'll reopen until @henriqueiamarino confirms it works |
…stream repo isn't allowed (#1392) When the GitHub export flow used a forked repository, it would still attempt to create a branch in the upstream repository. This resulted in the following cryptic error: > There was an unexpected error (Not Found), please try again. If the > problem persists, please report it at https://github.com/WordPress/ > wordpress-playground/issues. This PR ensures that branch is created in the push target ## Testing instructions 1. Import an `upsidedown` theme from https://github.com/Automattic/themes 2. Run `await playground.writeFile('/wordpress/wp-content/themes/upsidedown/test.txt', 'test');` in devtools 3. Try to export the changes as a PR, confirm a PR got created Closes #1367
I am having the following error while trying to export a theme update to Github:
"There was an unexpected error (Not Found); please try again. If the problem persists, please report it at https://github.com/WordPress/wordpress-playground/issues."
This is ultimately blocking my use of Playground for now.
The text was updated successfully, but these errors were encountered: